Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2229383003: chromeos: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/0a409a752f949a5b34dfaf091890715adfe4d31c Cr-Commit-Position: refs/heads/master@{#411610}

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : Formatting #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M chromeos/audio/audio_devices_pref_handler_stub.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_device_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/nfc_client_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/disks/mock_disk_mount_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/client_cert_resolver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_configuration_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/settings/timezone_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (18 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 14:15:00 UTC) #8
stevenjb
lgtm
4 years, 4 months ago (2016-08-10 17:07:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229383003/60001
4 years, 4 months ago (2016-08-12 12:15:54 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-12 12:21:22 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:23:02 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0a409a752f949a5b34dfaf091890715adfe4d31c
Cr-Commit-Position: refs/heads/master@{#411610}

Powered by Google App Engine
This is Rietveld 408576698