Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2229343002: [turbofan] Improve typing for CheckBounds. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typing for CheckBounds. Also eliminate redundant CheckBounds node during SimplifiedLowering if we can prove that the index is within the [0.0, length[ range. R=epertoso@chromium.org Committed: https://crrev.com/da2a53552e943fdce02baa9550d3d586f4109a88 Cr-Commit-Position: refs/heads/master@{#38523}

Patch Set 1 #

Patch Set 2 : Fix redundancy check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-10 07:56:49 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-10 08:37:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229343002/20001
4 years, 4 months ago (2016-08-10 08:37:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 08:49:20 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 08:49:38 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da2a53552e943fdce02baa9550d3d586f4109a88
Cr-Commit-Position: refs/heads/master@{#38523}

Powered by Google App Engine
This is Rietveld 408576698