Add compiled_resources2.gyp for file manager.

Add compiled_resources2.gyp for file manager.

BUG=636289
Committed: https://crrev.com/7687f1db33215f5d07bf201727cf4817ef52a88d
Cr-Commit-Position: refs/heads/master@{#412764}

[fukino, 2016-08-10 08:03:03]

Description was changed from

==========
Add compiled_resources2.gyp for file manager.

BUG=
==========

to

==========
Add compiled_resources2.gyp for file manager.

BUG=585553
==========

[fukino, 2016-08-10 08:03:03]

fukino@chromium.org changed reviewers:
+ yamaguchi@chromium.org

[fukino, 2016-08-10 08:19:04]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 08:19:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 09:05:39]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-08-10 09:26:46]

Description was changed from

==========
Add compiled_resources2.gyp for file manager.

BUG=585553
==========

to

==========
Add compiled_resources2.gyp for file manager.

BUG=636289
==========

[fukino, 2016-08-11 19:14:06]

Oops, this CL was not sent for review.
PTAL. Thanks!

[yamaguchi, 2016-08-16 01:52:00]

lgtm

[Dan Beam, 2016-08-16 02:10:13]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-08-16 02:10:14]

so what's the plan after this?

[fukino, 2016-08-17 02:52:19]

On 2016/08/16 02:10:14, Dan Beam wrote:
> so what's the plan after this?

We're going to uncomment targets gradually.
Locally I uncommented
ui/file_manager/file_manager/common/js/compiled_resources2.gyp (most depended
one), and I already have fair amount of non-trivial changes, so we'll avoid
doing the work at once.

As it needs more time, maybe we should go straight to .gn syntax?

[Dan Beam, 2016-08-17 17:40:13]

On 2016/08/17 02:52:19, fukino wrote:
> On 2016/08/16 02:10:14, Dan Beam wrote:
> > so what's the plan after this?
> 
> We're going to uncomment targets gradually.
> Locally I uncommented
> ui/file_manager/file_manager/common/js/compiled_resources2.gyp (most depended
> one), and I already have fair amount of non-trivial changes, so we'll avoid
> doing the work at once.
> 
> As it needs more time, maybe we should go straight to .gn syntax?

i don't know that gn is permissive of circular dependencies

[fukino, 2016-08-18 05:32:16]

On 2016/08/17 17:40:13, Dan Beam wrote:
> On 2016/08/17 02:52:19, fukino wrote:
> > On 2016/08/16 02:10:14, Dan Beam wrote:
> > > so what's the plan after this?
> > 
> > We're going to uncomment targets gradually.
> > Locally I uncommented
> > ui/file_manager/file_manager/common/js/compiled_resources2.gyp (most
depended
> > one), and I already have fair amount of non-trivial changes, so we'll avoid
> > doing the work at once.
> > 
> > As it needs more time, maybe we should go straight to .gn syntax?
> 
> i don't know that gn is permissive of circular dependencies

We will remove circular dependencies.
My concern is that the delay of file manager v2 migration may block the v2->gn
migration.

For now, we'll start v2 migration. If our delay of v2 migration blocks your gn
migration and direct migration to gn makes more sense, please let us know.

[fukino, 2016-08-18 05:32:22]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-08-18 05:32:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:12:59]

Description was changed from

==========
Add compiled_resources2.gyp for file manager.

BUG=636289
==========

to

==========
Add compiled_resources2.gyp for file manager.

BUG=636289
==========

[commit-bot: I haz the power, 2016-08-18 08:13:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 08:15:46]

Description was changed from

==========
Add compiled_resources2.gyp for file manager.

BUG=636289
==========

to

==========
Add compiled_resources2.gyp for file manager.

BUG=636289

Committed: https://crrev.com/7687f1db33215f5d07bf201727cf4817ef52a88d
Cr-Commit-Position: refs/heads/master@{#412764}
==========

[commit-bot: I haz the power, 2016-08-18 08:15:48]

Patchset 1 (id:??) landed as
https://crrev.com/7687f1db33215f5d07bf201727cf4817ef52a88d
Cr-Commit-Position: refs/heads/master@{#412764}