Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 222933004: android envsetup: Stop exporting CHROME_SRC, CURRENT_DIR (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

android envsetup: Stop exporting CHROME_SRC, CURRENT_DIR, SCRIPT_DIR. CHROME_SRC is only used inside of envsetup, there's no need to export it. Depends on https://chrome-internal-review.googlesource.com/159331/ It looks like CURRENT_DIR and SCRIPT_DIR weren't exported intentionally. Use "local" (which requires putting most of the code in this script in a function) to make sure they don't make it into the environment that envsetup is sourced from. BUG=330631 NOTRY=true R=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262292

Patch Set 1 #

Patch Set 2 : diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M build/android/envsetup.sh View 1 1 chunk +36 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 8 months ago (2014-04-07 22:56:52 UTC) #1
Nico
Ignore this for now, apparently not saying "export" doesn't prevent the variable from being set ...
6 years, 8 months ago (2014-04-07 22:58:51 UTC) #2
Nico
Ok, please take a look. (For the bots, the "local" apparently doesn't make a difference, ...
6 years, 8 months ago (2014-04-07 23:07:56 UTC) #3
Yaron
lgtm
6 years, 8 months ago (2014-04-07 23:10:23 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-08 02:44:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/222933004/20001
6 years, 8 months ago (2014-04-08 02:44:49 UTC) #6
Nico
6 years, 8 months ago (2014-04-08 03:53:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r262292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698