third_party/WebKit/Source/modules/fetch/BytesConsumer.h - Issue 2229313002: Make FetchDataLoader accept BytesConsumer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BytesConsumer.h

Issue 2229313002: Make FetchDataLoader accept BytesConsumer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-c++-rs

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/BytesConsumer.h

diff --git a/third_party/WebKit/Source/modules/fetch/BytesConsumer.h b/third_party/WebKit/Source/modules/fetch/BytesConsumer.h

index d822e752df476febb9e598f6952d587187f2a366..83288c716115866b3a4e7f522fab1fc9abb9a68c 100644

--- a/third_party/WebKit/Source/modules/fetch/BytesConsumer.h

+++ b/third_party/WebKit/Source/modules/fetch/BytesConsumer.h

@@ -58,7 +58,9 @@ public:

// This function is called when the state changes. This function can

// be called more than needed, i.e., it can be called even when the

- // state is not actually changed.

+ // state is not actually changed, but it is guaranteed that this

+ // function cannot be called when the state is closed or errored before

hiroshige 2016/08/15 07:09:57 nit: how about "... but it is guaranteed that this

yhirano 2016/08/16 09:02:21 Done.

+ // this function is called.

// This function is not called when the state change is trigerred by

// public methods called by a user. For example, when a user reads