Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2229303002:
Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" (Closed)
|
Created:
4 years, 4 months ago by trchen Modified:
4 years, 4 months ago Reviewers:
bokan CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert "Remove extraneous frameView->setNeedsLayout() in LayoutPart"
Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4
The commit is suspected to cause a memory regression. The root cause is not
trivial. Revert it first while we research the issue.
BUG=633199
Committed: https://crrev.com/329f73bb8976808995da6fb5f9783ac5aed7d128
Cr-Commit-Position: refs/heads/master@{#411867}
Patch Set 1 #Patch Set 2 : Disable fast/repaint/resize-iframe-text.html #Patch Set 3 : windows too. :( #
Messages
Total messages: 33 (20 generated)
Description was changed from ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 ========== to ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. TBR=bokan@chromium.org BUG=633199 ==========
trchen@chromium.org changed reviewers: + bokan@chromium.org
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. TBR=bokan@chromium.org BUG=633199 ========== to ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 ==========
Surprising that this would cause a memory regressions but lgtm.
The CQ bit was checked by trchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by trchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by trchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by trchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org Link to the patchset: https://codereview.chromium.org/2229303002/#ps20001 (title: "Disable fast/repaint/resize-iframe-text.html")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by trchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org Link to the patchset: https://codereview.chromium.org/2229303002/#ps40001 (title: "windows too. :(")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 ========== to ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 ========== to ========== Revert "Remove extraneous frameView->setNeedsLayout() in LayoutPart" Manually reverts https://crrev.com/6f72ce705eea7d49483b1cc75439260ebde643c4 The commit is suspected to cause a memory regression. The root cause is not trivial. Revert it first while we research the issue. BUG=633199 Committed: https://crrev.com/329f73bb8976808995da6fb5f9783ac5aed7d128 Cr-Commit-Position: refs/heads/master@{#411867} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/329f73bb8976808995da6fb5f9783ac5aed7d128 Cr-Commit-Position: refs/heads/master@{#411867} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
