tools/tests/skimage/input/images-with-known-hashes/ignore-failures.json - Issue 22293006: Truly ignore failures in skimage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/tests/skimage/input/images-with-known-hashes/ignore-failures.json

Issue 22293006: Truly ignore failures in skimage. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: More tests! Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tools/skimage_main.cpp ('K') | « tools/tests/skimage/input/bad-images/invalid.png ('k') | tools/tests/skimage/input/images-with-known-hashes/incorrect-results.json » ('j') | tools/tests/skimage/input/images-with-known-hashes/incorrect-results.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "actual-results" : {

	3 "failed" : null,

	4 "failure-ignored" : null,

	5 "no-comparison" : null,

	6 "succeeded" : null

	7 },

	8 "expected-results" : {

	9 "1209453360120438698.png" : {

	10 "allowed-digests" : [

	11 [ "bitmap-64bitMD5", 1209453360120438600 ]
	scroggo 2013/10/14 21:44:38 Should I add a comment that I've manually modified Should I add a comment that I've manually modified this hash to be invalid? (Would that be done by using a '#'? in a json file?) epoger 2013/10/15 15:31:03 JSON does not allow comments. See http://stackove Show quoted text On 2013/10/14 21:44:38, scroggo wrote: > Should I add a comment that I've manually modified this hash to be invalid? > (Would that be done by using a '#'? in a json file?) JSON does not allow comments. See http://stackoverflow.com/questions/244777/can-i-comment-a-json-file It's good to know we have new religious wars that can take over for vi-vs-emacs. Maybe just make this an obviously made-up digest, like 111111 ? scroggo 2013/10/15 19:50:59 Done. Show quoted text On 2013/10/15 15:31:03, epoger wrote: > On 2013/10/14 21:44:38, scroggo wrote: > > Should I add a comment that I've manually modified this hash to be invalid? > > (Would that be done by using a '#'? in a json file?) > > JSON does not allow comments. See > http://stackoverflow.com/questions/244777/can-i-comment-a-json-file > > It's good to know we have new religious wars that can take over for vi-vs-emacs. > > Maybe just make this an obviously made-up digest, like 111111 ? Done.
	12 ],

	13 "ignore-failure" : true

	14 }

	15 }

	16 }

OLD	NEW