Convert Budget to BudgetService.

Convert Budget to BudgetService.

In the specification, the NavigatorBudget has a BudgetService member, not a
Budget member. Converting the code to match the spec.

BUG=617971
Committed: https://crrev.com/eba38fdd93655ae7f7116e3c7846b5607e0ce3c5
Cr-Commit-Position: refs/heads/master@{#411316}

[harkness, 2016-08-10 17:09:31]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[harkness, 2016-08-10 17:09:32]

https://codereview.chromium.org/2229283003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/budget/BudgetService.h (right):

https://codereview.chromium.org/2229283003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/budget/BudgetService.h:19: class BudgetService
final : public GarbageCollected<BudgetService>, public ScriptWrappable {
I don't really know whether to wrap this line, and if so, how to do it.

If I wrap it like this:

class BudgetService final
    : public GarbageCollected<BudgetService>
    , public ScriptWrappable

then git cl format changes it to be the following:

class BudgetService final
    : public GarbageCollected<BudgetService>,
      public ScriptWrappable

and then git cl upload refuses to upload that because of the 6 spaces at the
start of the line not being correct.

I've seen a few places in the code where the line is allowed to wrap in this
case, but I don't know whether that's actually allowed or not.

[Peter Beverloo, 2016-08-10 18:03:28]

In principle I'm fine with this, but we do need to think about naming.

Considering the current situation, we'd have the BudgetService (Blink Module)
talking to the BudgetService (Mojo interface), implemented by the
BudgetServiceImpl (//chrome/browser) that talks to the BackgroundBudgetService.

While it feels appropriate (minus the last one), it doesn't strike me as an
ideal situation.

lgtm % your thoughts

https://codereview.chromium.org/2229283003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/budget/BudgetService.h (right):

https://codereview.chromium.org/2229283003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/budget/BudgetService.h:19: class BudgetService
final : public GarbageCollected<BudgetService>, public ScriptWrappable {
On 2016/08/10 17:09:32, harkness wrote:
> I don't really know whether to wrap this line, and if so, how to do it.
> 
> If I wrap it like this:
> 
> class BudgetService final
>     : public GarbageCollected<BudgetService>
>     , public ScriptWrappable
> 
> then git cl format changes it to be the following:
> 
> class BudgetService final
>     : public GarbageCollected<BudgetService>,
>       public ScriptWrappable
> 
> and then git cl upload refuses to upload that because of the 6 spaces at the
> start of the line not being correct.
> 
> I've seen a few places in the code where the line is allowed to wrap in this
> case, but I don't know whether that's actually allowed or not.

There are no line length limits in Blink, no need to wrap at all.

[harkness, 2016-08-11 10:37:43]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-08-11 10:37:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 11:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 11:44:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[harkness, 2016-08-11 12:09:17]

The CQ bit was checked by harkness@chromium.org

[harkness, 2016-08-11 12:09:17]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2229283003/#ps20001
(title: "Updated global interface list")

[commit-bot: I haz the power, 2016-08-11 12:09:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 13:55:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 13:56:49]

Description was changed from

==========
Convert Budget to BudgetService.

In the specification, the NavigatorBudget has a BudgetService member, not a
Budget member. Converting the code to match the spec.

BUG=617971
==========

to

==========
Convert Budget to BudgetService.

In the specification, the NavigatorBudget has a BudgetService member, not a
Budget member. Converting the code to match the spec.

BUG=617971

Committed: https://crrev.com/eba38fdd93655ae7f7116e3c7846b5607e0ce3c5
Cr-Commit-Position: refs/heads/master@{#411316}
==========

[commit-bot: I haz the power, 2016-08-11 13:56:50]

Patchset 2 (id:??) landed as
https://crrev.com/eba38fdd93655ae7f7116e3c7846b5607e0ce3c5
Cr-Commit-Position: refs/heads/master@{#411316}