Destructuring/default tests for generators and async functions

Destructuring/default tests for generators and async functions

This patch adds additional tests for async functions and generators, in how
they interact with destructuring, default arguments and shadow parameter
copying.

BUG=v8:5167
Committed: https://crrev.com/7ea3b0998232aec6b0ed1208d8214f4e50c17cd8
Cr-Commit-Position: refs/heads/master@{#38560}

[Dan Ehrenberg, 2016-08-10 01:33:33]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-08-10 01:53:32]

littledan@chromium.org changed reviewers:
+ neis@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:54:48]

Dry run: This issue passed the CQ dry run.

[neis, 2016-08-10 09:29:29]

lgtm with minor comments. I haven't looked closely at the async tests, though.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
File test/mjsunit/es6/generator-destructuring.js (right):

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:52: 
I don't understand the comment on f21. Also the function is not used, are you
only asserting that it doesn't produce a SyntaxError?

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:57: }());
No need for applying f in these four cases.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:313: assertThrows(function(){
eval("function*(x=1){'use strict';}") }, SyntaxError);
I think you're testing the wrong SyntaxError here because this is a declaration
that is missing a name. Give it a name or put parens around.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:316: function(){ eval("function*(a,
x=1){'use strict';}") }, SyntaxError);
Same here.

Maybe also test with a non-simple but non-expression parameter:
function* f({a}){'use strict';}

[Dan Ehrenberg, 2016-08-10 18:29:34]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-08-10 18:29:35]

Updated the tests per your suggestions.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
File test/mjsunit/es6/generator-destructuring.js (right):

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:52: 
On 2016/08/10 at 09:29:29, neis wrote:
> I don't understand the comment on f21. Also the function is not used, are you
only asserting that it doesn't produce a SyntaxError?

Oops, added the test. I had accidentally deleted it when copying over from the
ordinary function tests in mjsunit/es6/destructuring. The hoisting is blocked by
Annex B 3.3. The new test is more precise than previously.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:57: }());
On 2016/08/10 at 09:29:29, neis wrote:
> No need for applying f in these four cases.

Done

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:313: assertThrows(function(){
eval("function*(x=1){'use strict';}") }, SyntaxError);
On 2016/08/10 at 09:29:29, neis wrote:
> I think you're testing the wrong SyntaxError here because this is a
declaration that is missing a name. Give it a name or put parens around.

Oops, fixed in all copies.

https://codereview.chromium.org/2229243002/diff/1/test/mjsunit/es6/generator-...
test/mjsunit/es6/generator-destructuring.js:316: function(){ eval("function*(a,
x=1){'use strict';}") }, SyntaxError);
On 2016/08/10 at 09:29:29, neis wrote:
> Same here.
> 
> Maybe also test with a non-simple but non-expression parameter:
> function* f({a}){'use strict';}

Done.

[Dan Ehrenberg, 2016-08-10 18:29:36]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2229243002/#ps30001
(title: "Add additional suggested test")

[commit-bot: I haz the power, 2016-08-10 18:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:32:12]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-08-10 19:32:34]

Description was changed from

==========
Destructuring/default tests for generators and async functions

This patch adds additional tests for async functions and generators, in how
they interact with destructuring, default arguments and shadow parameter
copying.

BUG=v8:5167
==========

to

==========
Destructuring/default tests for generators and async functions

This patch adds additional tests for async functions and generators, in how
they interact with destructuring, default arguments and shadow parameter
copying.

BUG=v8:5167

Committed: https://crrev.com/7ea3b0998232aec6b0ed1208d8214f4e50c17cd8
Cr-Commit-Position: refs/heads/master@{#38560}
==========

[commit-bot: I haz the power, 2016-08-10 19:32:35]

Patchset 3 (id:??) landed as
https://crrev.com/7ea3b0998232aec6b0ed1208d8214f4e50c17cd8
Cr-Commit-Position: refs/heads/master@{#38560}