Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2229233002: Call IDirectManipulationViewport::Abandon before releasing viewport. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call IDirectManipulationViewport::Abandon before releasing viewport. Otherwise there's a reference cycle and about 4KB is leaked. BUG=636176 Committed: https://crrev.com/d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd Cr-Commit-Position: refs/heads/master@{#410936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/gfx/win/direct_manipulation.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
jbauman
4 years, 4 months ago (2016-08-10 01:43:58 UTC) #5
ananta
lgtm
4 years, 4 months ago (2016-08-10 02:41:11 UTC) #8
sky
Rubber stamp LGTM - I'm not familiar with this code at all. I think one ...
4 years, 4 months ago (2016-08-10 02:45:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229233002/1
4 years, 4 months ago (2016-08-10 03:04:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 03:07:47 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 03:09:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d48b65a4b84e0ca652bf5ab39abaf0809ba4b6cd
Cr-Commit-Position: refs/heads/master@{#410936}

Powered by Google App Engine
This is Rietveld 408576698