Reflection on generics.

tests/lib/mirrors/generics_test.dart

Index: tests/lib/mirrors/generics_test.dart
diff --git a/tests/lib/mirrors/generics_test.dart b/tests/lib/mirrors/generics_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..6606ebca76e14fc26ffbb0b5f6061aded1d21124
--- /dev/null
+++ b/tests/lib/mirrors/generics_test.dart
@@ -0,0 +1,104 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library test.type_arguments_test;
+
+import 'dart:mirrors';
+
+import 'package:expect/expect.dart';
+
+class A<T> {}
+class B extends A {}            // Same as class B extends A<dynamic>.
+class C extends A<num, int> {}  // Same as class C extends A<dynamic>.

[gbracha, 2013/08/05 21:55:31]

Comment is wrong.

[ahe, 2013/08/06 16:45:43]

Why?

+class D extends A<int> {}
+class E<S> extends A<S> {}
+class F<R> extends A<int> {}
+class G {}
+
+typeParameters(mirror, parameterNames){

[ahe, 2013/08/06 16:45:43]

Space before {

+  Expect.listEquals(parameterNames.map((n) => new Symbol(n)).toList(),
+                    mirror.typeVariables.keys.toList());
+}
+
+typeArguments(mirror, argumentMirrors){

[ahe, 2013/08/06 16:45:43]

Ditto.

+  Expect.listEquals(argumentMirrors,
+                    mirror.typeArguments.values.toList());
+}
+
+main() {
+  // Declarations.
+  typeParameters(reflectClass(A), ['T']);
+  typeParameters(reflectClass(B), []);
+  typeParameters(reflectClass(C), []);
+  typeParameters(reflectClass(D), []);
+  typeParameters(reflectClass(E), ['S']);
+  typeParameters(reflectClass(F), ['R']);
+  typeParameters(reflectClass(G), []);
+
+  typeArguments(reflectClass(A), []);
+  typeArguments(reflectClass(B), []);
+  typeArguments(reflectClass(C), []);
+  typeArguments(reflectClass(D), []);
+  typeArguments(reflectClass(E), []);
+  typeArguments(reflectClass(F), []);
+  typeArguments(reflectClass(G), []);
+
+  Expect.isTrue(reflectClass(A).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(B).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(C).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(D).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(E).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(F).isOriginalDeclaration);
+  Expect.isTrue(reflectClass(G).isOriginalDeclaration);
+
+  Expect.equals(reflectClass(A), reflectClass(A).originalDeclaration);
+  Expect.equals(reflectClass(B), reflectClass(B).originalDeclaration);
+  Expect.equals(reflectClass(C), reflectClass(C).originalDeclaration);
+  Expect.equals(reflectClass(D), reflectClass(D).originalDeclaration);
+  Expect.equals(reflectClass(E), reflectClass(E).originalDeclaration);
+  Expect.equals(reflectClass(F), reflectClass(F).originalDeclaration);
+  Expect.equals(reflectClass(G), reflectClass(G).originalDeclaration);
+
+  // Instantiations.
+  typeParameters(reflect(new A<num>()).type, ['T']);
+  typeParameters(reflect(new B<num>()).type, ['']);

[gbracha, 2013/08/05 21:55:31]

Why do you sometimes use a list with an empty string and sometimes an empty
list? Empty list is cleaner.
Ditto two lines below.

+  typeParameters(reflect(new C     ()).type, ['']);
+  typeParameters(reflect(new D     ()).type, ['']);
+  typeParameters(reflect(new E     ()).type, ['S']);
+  typeParameters(reflect(new F<num>()).type, ['R']);
+  typeParameters(reflect(new G()).type, []);
+
+  var numMirror = reflectClass(num);
+  typeArguments(reflect(new A<num>()).type, [numMirror]);
+  typeArguments(reflect(new B     ()).type, []);
+  typeArguments(reflect(new C     ()).type, []);
+  typeArguments(reflect(new D     ()).type, []);
+  typeArguments(reflect(new E<num>()).type, [numMirror]);
+  typeArguments(reflect(new F<num>()).type, [numMirror]);
+  typeArguments(reflect(new G     ()).type, []);
+
+  Expect.isFalse(reflect(new A<num>()).type.isOriginalDeclaration);
+  Expect.isTrue (reflect(new B     ()).type.isOriginalDeclaration);
+  Expect.isTrue (reflect(new C     ()).type.isOriginalDeclaration);
+  Expect.isTrue (reflect(new D     ()).type.isOriginalDeclaration);
+  Expect.isFalse(reflect(new E<num>()).type.isOriginalDeclaration);
+  Expect.isFalse(reflect(new F<num>()).type.isOriginalDeclaration);
+  Expect.isTrue (reflect(new G     ()).type.isOriginalDeclaration);
+
+  Expect.equals(reflectClass(A), reflect(new A<num>()).type.originalDeclaration);

[ahe, 2013/08/06 16:45:43]

Long lines.

+  Expect.equals(reflectClass(B), reflect(new B     ()).type.originalDeclaration);

[ahe, 2013/08/06 16:45:43]

Please don't use ASCII art, that is, remove the extra spaces.

+  Expect.equals(reflectClass(C), reflect(new C     ()).type.originalDeclaration);
+  Expect.equals(reflectClass(D), reflect(new D     ()).type.originalDeclaration);
+  Expect.equals(reflectClass(E), reflect(new E<num>()).type.originalDeclaration);
+  Expect.equals(reflectClass(F), reflect(new F<num>()).type.originalDeclaration);
+  Expect.equals(reflectClass(G), reflect(new G     ()).type.originalDeclaration);
+
+  // Library members are all uninstantaited generics or non-generics.
+  currentMirrorSystem().libraries.values.forEach((libraryMirror) {
+    libraryMirrors.classes.values.forEach((classMirror) {

[gbracha, 2013/08/05 21:55:31]

Isn't it libraryMirror rather than libraryMirrors?

+      Expect.isTrue(classMirror.isOriginalDeclaration);
+      Expect.equals(classMirror, classMirror.originalDeclaration);
+    }
+  });
+}