Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 222913003: Add button to reset auto-open pref in Chrome OS settings (Closed)

Created:
6 years, 8 months ago by michaelpg
Modified:
6 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Add button to reset auto-open pref in Chrome OS settings BUG=347149 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261705

Patch Set 1 #

Patch Set 2 : Change padding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M chrome/browser/resources/options/browser_options.css View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaelpg
Stop hiding this button on Chrome OS.
6 years, 8 months ago (2014-04-02 20:56:03 UTC) #1
Dan Beam
i don't see kuscher@'s answer on the bug. also, I wonder why it looks bad ...
6 years, 8 months ago (2014-04-02 21:14:11 UTC) #2
Dan Beam
also, why wasn't this enabled on CrOS? are you sure this works/there's a pref for ...
6 years, 8 months ago (2014-04-02 21:15:14 UTC) #3
michaelpg
Apparently, the auto-open label had a custom padding specified. I've removed this and used the ...
6 years, 8 months ago (2014-04-03 19:53:43 UTC) #4
Dan Beam
lgtm
6 years, 8 months ago (2014-04-04 02:49:40 UTC) #5
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 8 months ago (2014-04-04 03:50:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/222913003/20001
6 years, 8 months ago (2014-04-04 03:50:47 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 08:26:21 UTC) #8
Message was sent while issue was closed.
Change committed as 261705

Powered by Google App Engine
This is Rietveld 408576698