Add another PDFEditTest test case.

Add another PDFEditTest test case.

BUG=pdfium:545
Committed: https://pdfium.googlesource.com/pdfium/+/85af2a3cfcdfb2200510d337bfbf5b405858aa3b

[Lei Zhang, 2016-08-09 23:13:13]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Lei Zhang, 2016-08-09 23:13:19]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 23:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rduckles, 2016-08-09 23:21:00]

rduckles@gmail.com changed reviewers:
+ rduckles@gmail.com

[rduckles, 2016-08-09 23:21:01]

lgtm

[commit-bot: I haz the power, 2016-08-09 23:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:28:15]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-09 23:39:19]

lgtm

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
File fpdfsdk/fpdfeditimg_unittest.cpp (right):

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
fpdfsdk/fpdfeditimg_unittest.cpp:62: EXPECT_EQ(kBitmapSize, bitmap_height);
Nit: may remove |bitmap_width| and |bitmap_height|. Use kBitmapSize directly in
the following calls.

[Lei Zhang, 2016-08-09 23:48:34]

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
File fpdfsdk/fpdfeditimg_unittest.cpp (right):

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
fpdfsdk/fpdfeditimg_unittest.cpp:62: EXPECT_EQ(kBitmapSize, bitmap_height);
On 2016/08/09 23:39:19, Wei Li wrote:
> Nit: may remove |bitmap_width| and |bitmap_height|. Use kBitmapSize directly
in
> the following calls.

I know the focus of this test is not FPDFBitmap_Get{Width,Height} but it does
not hurt to exercise them a bit more.

[Lei Zhang, 2016-08-09 23:50:33]

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
File fpdfsdk/fpdfeditimg_unittest.cpp (right):

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
fpdfsdk/fpdfeditimg_unittest.cpp:62: EXPECT_EQ(kBitmapSize, bitmap_height);
On 2016/08/09 23:39:19, Wei Li wrote:
> Nit: may remove |bitmap_width| and |bitmap_height|. Use kBitmapSize directly
in
> the following calls.

Done.

[Lei Zhang, 2016-08-09 23:50:54]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-08-09 23:50:54]

The patchset sent to the CQ was uploaded after l-g-t-m from weili@chromium.org,
rduckles@gmail.com
Link to the patchset: https://codereview.chromium.org/2229103003/#ps20001
(title: "use bitmap size constant more")

[commit-bot: I haz the power, 2016-08-09 23:50:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-08-09 23:51:16]

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
File fpdfsdk/fpdfeditimg_unittest.cpp (right):

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
fpdfsdk/fpdfeditimg_unittest.cpp:62: EXPECT_EQ(kBitmapSize, bitmap_height);
On 2016/08/09 23:48:34, Lei Zhang wrote:
> On 2016/08/09 23:39:19, Wei Li wrote:
> > Nit: may remove |bitmap_width| and |bitmap_height|. Use kBitmapSize directly
> in
> > the following calls.
> 
> I know the focus of this test is not FPDFBitmap_Get{Width,Height} but it does
> not hurt to exercise them a bit more.

What I meant is you can use:
EXPECT_EQ(kBitmapSize, FPDFBitmap_GetWidth(bitmap));
EXPECT_EQ(kBitmapSize, FPDFBitmap_GetHeight(bitmap));

[Lei Zhang, 2016-08-09 23:53:07]

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
File fpdfsdk/fpdfeditimg_unittest.cpp (right):

https://codereview.chromium.org/2229103003/diff/1/fpdfsdk/fpdfeditimg_unittes...
fpdfsdk/fpdfeditimg_unittest.cpp:62: EXPECT_EQ(kBitmapSize, bitmap_height);
On 2016/08/09 23:51:16, Wei Li wrote:
> On 2016/08/09 23:48:34, Lei Zhang wrote:
> > On 2016/08/09 23:39:19, Wei Li wrote:
> > > Nit: may remove |bitmap_width| and |bitmap_height|. Use kBitmapSize
directly
> > in
> > > the following calls.
> > 
> > I know the focus of this test is not FPDFBitmap_Get{Width,Height} but it
does
> > not hurt to exercise them a bit more.
> 
> What I meant is you can use:
> EXPECT_EQ(kBitmapSize, FPDFBitmap_GetWidth(bitmap));
> EXPECT_EQ(kBitmapSize, FPDFBitmap_GetHeight(bitmap));

Yep. Patch set 2.

[commit-bot: I haz the power, 2016-08-10 00:13:17]

Description was changed from

==========
Add another PDFEditTest test case.

BUG=pdfium:545
==========

to

==========
Add another PDFEditTest test case.

BUG=pdfium:545

Committed:
https://pdfium.googlesource.com/pdfium/+/85af2a3cfcdfb2200510d337bfbf5b405858...
==========

[commit-bot: I haz the power, 2016-08-10 00:13:18]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/85af2a3cfcdfb2200510d337bfbf5b405858...