ash/system/tray/tray_constants.cc - Issue 22291003: ash:Shelf Update Alternate Layout

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/system/tray/tray_constants.cc

Issue 22291003: ash:Shelf Update Alternate Layout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« ash/system/status_area_widget_delegate.cc ('K') | « ash/system/tray/tray_constants.h ('k') | ash/system/web_notification/web_notification_tray.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/system/tray/tray_constants.h"	5 #include "ash/system/tray/tray_constants.h"

6	6

7 #include "third_party/skia/include/core/SkColor.h"	7 #include "third_party/skia/include/core/SkColor.h"

8	8

9 namespace ash {	9 namespace ash {

10	10

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 const SkColor kHeaderTextColorHover = SkColorSetARGB(0xd3, 0, 0, 0);	58 const SkColor kHeaderTextColorHover = SkColorSetARGB(0xd3, 0, 0, 0);

59	59

60 const int kTrayPopupMinWidth = 300;	60 const int kTrayPopupMinWidth = 300;

61 const int kTrayPopupMaxWidth = 500;	61 const int kTrayPopupMaxWidth = 500;

62 const int kNotificationIconWidth = 40;	62 const int kNotificationIconWidth = 40;

63 const int kNotificationButtonWidth = 32;	63 const int kNotificationButtonWidth = 32;

64 const int kTrayNotificationContentsWidth = kTrayPopupMinWidth -	64 const int kTrayNotificationContentsWidth = kTrayPopupMinWidth -

65 (kNotificationIconWidth + kNotificationButtonWidth +	65 (kNotificationIconWidth + kNotificationButtonWidth +

66 (kTrayPopupPaddingHorizontal / 2) * 3);	66 (kTrayPopupPaddingHorizontal / 2) * 3);

67 const int kTraySpacing = 8;	67 const int kTraySpacing = 8;

	68 const int kAlternateTraySpacing = 4;
	Mr4D (OOO till 08-26) 2013/08/06 21:10:34 This feels rather odd. If in all cases where kTray This feels rather odd. If in all cases where kTraySpacing is used, kAlternateTraySpacing should get used you should possibly create a function to access it and not offer the constant this way. That said - I know that this is (hopefully) temporary code and will get removed soon. As such it might also simply stay as it is.
68	69

69 } // namespace ash	70 } // namespace ash

OLD	NEW