Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2229063002: Remove GN forwarding of the target variables. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@args_impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GN forwarding of the target variables. The Posix toolchain definitions forwarded the target_cpu and target_os to all secondary toolchains. But the computation of these values should be invariant of the toolchain. This removes the forwarding. Committed: https://crrev.com/ec467a46f0e8760fae1928e4040d053caae843df Cr-Commit-Position: refs/heads/master@{#410883}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +4 lines, -7 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 1 chunk +4 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
brettw
4 years, 4 months ago (2016-08-09 18:13:31 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2229063002/diff/1/build/toolchain/gcc_toolchain.gni File build/toolchain/gcc_toolchain.gni (right): https://codereview.chromium.org/2229063002/diff/1/build/toolchain/gcc_toolchain.gni#newcode102 build/toolchain/gcc_toolchain.gni:102: # The host toolchain value computed by the ...
4 years, 4 months ago (2016-08-09 18:37:42 UTC) #5
brettw
fixes
4 years, 4 months ago (2016-08-09 19:06:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229063002/20001
4 years, 4 months ago (2016-08-09 22:53:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 00:01:29 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 00:03:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec467a46f0e8760fae1928e4040d053caae843df
Cr-Commit-Position: refs/heads/master@{#410883}

Powered by Google App Engine
This is Rietveld 408576698