Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3009)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 222903005: cc: Let skia veto gpu rasterization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index d6144890f39da9631f0192e786cb5e0798378cc6..4a35b62b833feb70ce772fcaefec7dbbab3a96d7 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -1502,7 +1502,7 @@ TEST_F(PictureLayerImplTest, SyncTilingAfterReleaseResource) {
EXPECT_TRUE(active_layer_->tilings()->TilingAtScale(tile_scale));
}
-TEST_F(PictureLayerImplTest, TilingWithoutGpuRasterization) {
+TEST_F(PictureLayerImplTest, NoLowResTilingWithGpuRasterization) {
gfx::Size default_tile_size(host_impl_.settings().default_tile_size);
gfx::Size layer_bounds(default_tile_size.width() * 4,
default_tile_size.height() * 4);
@@ -1516,6 +1516,14 @@ TEST_F(PictureLayerImplTest, TilingWithoutGpuRasterization) {
1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
// Should have a low-res and a high-res tiling.
ASSERT_EQ(2u, pending_layer_->tilings()->num_tilings());
+
+ pending_layer_->SetUseGpuRasterization(true);
+ EXPECT_TRUE(pending_layer_->ShouldUseGpuRasterization());
+ EXPECT_EQ(0u, pending_layer_->tilings()->num_tilings());
+ pending_layer_->CalculateContentsScale(
+ 1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
+ // Should only have the high-res tiling.
+ ASSERT_EQ(1u, pending_layer_->tilings()->num_tilings());
}
TEST_F(PictureLayerImplTest, NoTilingIfDoesNotDrawContent) {
@@ -1637,30 +1645,6 @@ class HybridRasterizationPictureLayerImplTest : public PictureLayerImplTest {
: PictureLayerImplTest(HybridRasterizationSettings()) {}
};
-TEST_F(HybridRasterizationPictureLayerImplTest, Tiling) {
- gfx::Size default_tile_size(host_impl_.settings().default_tile_size);
- gfx::Size layer_bounds(default_tile_size.width() * 4,
- default_tile_size.height() * 4);
- float result_scale_x, result_scale_y;
- gfx::Size result_bounds;
-
- SetupDefaultTrees(layer_bounds);
- EXPECT_FALSE(pending_layer_->ShouldUseGpuRasterization());
- EXPECT_EQ(0u, pending_layer_->tilings()->num_tilings());
- pending_layer_->CalculateContentsScale(
- 1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
- // Should have a low-res and a high-res tiling.
- ASSERT_EQ(2u, pending_layer_->tilings()->num_tilings());
-
- pending_layer_->SetHasGpuRasterizationHint(true);
- EXPECT_TRUE(pending_layer_->ShouldUseGpuRasterization());
- EXPECT_EQ(0u, pending_layer_->tilings()->num_tilings());
- pending_layer_->CalculateContentsScale(
- 1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
- // Should only have the high-res tiling.
- ASSERT_EQ(1u, pending_layer_->tilings()->num_tilings());
-}
-
TEST_F(HybridRasterizationPictureLayerImplTest,
HighResTilingDuringAnimationForCpuRasterization) {
gfx::Size tile_size(host_impl_.settings().default_tile_size);
@@ -1733,38 +1717,6 @@ TEST_F(HybridRasterizationPictureLayerImplTest,
EXPECT_BOTH_EQ(HighResTiling()->contents_scale(), 4.f);
}
-class GpuRasterizationPictureLayerImplTest : public PictureLayerImplTest {
- public:
- GpuRasterizationPictureLayerImplTest()
- : PictureLayerImplTest(GpuRasterizationSettings()) {}
-};
-
-TEST_F(GpuRasterizationPictureLayerImplTest, Tiling) {
- gfx::Size default_tile_size(host_impl_.settings().default_tile_size);
- gfx::Size layer_bounds(default_tile_size.width() * 4,
- default_tile_size.height() * 4);
- float result_scale_x, result_scale_y;
- gfx::Size result_bounds;
-
- SetupDefaultTrees(layer_bounds);
- pending_layer_->SetHasGpuRasterizationHint(true);
- EXPECT_TRUE(pending_layer_->ShouldUseGpuRasterization());
- EXPECT_EQ(0u, pending_layer_->tilings()->num_tilings());
- pending_layer_->CalculateContentsScale(
- 1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
- // Should only have the high-res tiling.
- ASSERT_EQ(1u, pending_layer_->tilings()->num_tilings());
-
- pending_layer_->SetHasGpuRasterizationHint(false);
- EXPECT_TRUE(pending_layer_->ShouldUseGpuRasterization());
- // Should still have the high-res tiling.
- EXPECT_EQ(1u, pending_layer_->tilings()->num_tilings());
- pending_layer_->CalculateContentsScale(
- 1.f, 1.f, 1.f, false, &result_scale_x, &result_scale_y, &result_bounds);
- // Should still only have the high-res tiling.
- ASSERT_EQ(1u, pending_layer_->tilings()->num_tilings());
-}
-
TEST_F(PictureLayerImplTest, LayerRasterTileIterator) {
gfx::Size tile_size(100, 100);
gfx::Size layer_bounds(1000, 1000);

Powered by Google App Engine
This is Rietveld 408576698