cc: Let skia veto gpu rasterization.

cc/layers/picture_layer.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer.h"
 
 #include "cc/layers/content_layer_client.h"
 #include "cc/layers/picture_layer_impl.h"
 #include "cc/trees/layer_tree_impl.h"
 #include "ui/gfx/rect_conversions.h"
 
 namespace cc {
 
 scoped_refptr<PictureLayer> PictureLayer::Create(ContentLayerClient* client) {
   return make_scoped_refptr(new PictureLayer(client));
 }
 
 PictureLayer::PictureLayer(ContentLayerClient* client)
     : client_(client),
       pile_(make_scoped_refptr(new PicturePile())),
       instrumentation_object_tracker_(id()),
       is_mask_(false),
-      has_gpu_rasterization_hint_(false),
+      has_gpu_rasterization_hint_(TRIBOOL_UNKNOWN),
       update_source_frame_number_(-1) {}
 
 PictureLayer::~PictureLayer() {
 }
 
 bool PictureLayer::DrawsContent() const {
   return Layer::DrawsContent() && client_;
 }
 
 scoped_ptr<LayerImpl> PictureLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
   return PictureLayerImpl::Create(tree_impl, id()).PassAs<LayerImpl>();
 }
 
 void PictureLayer::PushPropertiesTo(LayerImpl* base_layer) {
   Layer::PushPropertiesTo(base_layer);
   PictureLayerImpl* layer_impl = static_cast<PictureLayerImpl*>(base_layer);
 
   if (layer_impl->bounds().IsEmpty()) {
     // Update may not get called for an empty layer, so resize here instead.
     // Using layer_impl because either bounds() or paint_properties().bounds
     // may disagree and either one could have been pushed to layer_impl.
     pile_->Resize(gfx::Size());
   } else if (update_source_frame_number_ ==
              layer_tree_host()->source_frame_number()) {
     // If update called, then pile size must match bounds pushed to impl layer.
     DCHECK_EQ(layer_impl->bounds().ToString(), pile_->size().ToString());
   }
 
   layer_impl->SetIsMask(is_mask_);
-  layer_impl->SetHasGpuRasterizationHint(has_gpu_rasterization_hint_);
+  layer_impl->SetUseGpuRasterization(ShouldUseGpuRasterization());
 
   // Unlike other properties, invalidation must always be set on layer_impl.
   // See PictureLayerImpl::PushPropertiesTo for more details.
   layer_impl->invalidation_.Clear();
   layer_impl->invalidation_.Swap(&pile_invalidation_);
   layer_impl->pile_ = PicturePileImpl::CreateFromOther(pile_.get());
 }
 
 void PictureLayer::SetLayerTreeHost(LayerTreeHost* host) {
   Layer::SetLayerTreeHost(host);
@@ skipping 67 matching lines @@
   }
 
   return updated;
 }
 
 void PictureLayer::SetIsMask(bool is_mask) {
   is_mask_ = is_mask;
 }
 
 void PictureLayer::SetHasGpuRasterizationHint(bool has_hint) {
-  DCHECK(IsPropertyChangeAllowed());
-  if (has_gpu_rasterization_hint_ == has_hint)
-    return;
-  has_gpu_rasterization_hint_ = has_hint;
-  SetNeedsCommit();
+  switch (has_gpu_rasterization_hint_) {
+    case TRIBOOL_UNKNOWN:  // Fall-through.
+    case TRIBOOL_TRUE:
+      has_gpu_rasterization_hint_ = has_hint ? TRIBOOL_TRUE : TRIBOOL_FALSE;

[enne (OOO), 2014/04/04 19:40:07]

In other words, keep this function the same as before...

+      break;
+    case TRIBOOL_FALSE:
+      // GPU rasterization cannot be enabled once disabled.
+      // This is done to prevent frequent invalidations and visual flashing.
+      break;
+    default:
+      NOTREACHED();
+  }
+  // No need to commit immediately.
+  // This flag will be pushed with the next commit.
+}
+
+bool PictureLayer::ShouldUseGpuRasterization() const {
+  switch (layer_tree_host()->settings().rasterization_site) {
+    case LayerTreeSettings::CpuRasterization:
+      return false;
+    case LayerTreeSettings::HybridRasterization:
+      return has_gpu_rasterization_hint_ == TRIBOOL_TRUE &&

[enne (OOO), 2014/04/04 19:40:07]

...and just say has_gpu_rasterization_hint_ &&
pile_->is_suitable_for_gpu_rasterization().

It just seems like you're maintaining redundant state (the "has ever been
disabled" state) in the TRIBOOL and the pile suitability flag.

[alokp, 2014/04/04 21:53:46]

I do not think there is any redundancy. Both the flags - has-hint and
is-suitable - are sticky but controlled by two different independent signals -
will-change and skia-veto.

If I understand your proposal, it may not work if the content is always
gpu-suitable:
1. The default value of has-hint is false, so we raster with cpu.
2. SetHasGpuRasterizationHint(true)
3. Invalidation - contents is gpu-suitable
4. Raster with gpu
5. SetHasGpuRasterizationHint(false)
6. Invalidation - contents still gpu-suitable
7. Raster with cpu
8. SetHasGpuRasterizationHint(true)
9. Invalidation - contents still gpu-suitable
10. Raster with gpu

In short, we can keep switch between cpu and gpu if the content continues to be
gpu-suitable. Please let me know if you had something else in mind.

I have used boost::tribool in the past to represent unknown boolean state and it
seems appropriate in this case. A two-state boolean does not work because the
default state is the same as the sticky state. I can add another bool if it
makes it less confusing.

+             pile_->is_suitable_for_gpu_rasterization();
+    case LayerTreeSettings::GpuRasterization:
+      return true;
+  }
+  NOTREACHED();
+  return false;
 }
 
 bool PictureLayer::SupportsLCDText() const {
   return true;
 }
 
 skia::RefPtr<SkPicture> PictureLayer::GetPicture() const {
   // We could either flatten the PicturePile into a single SkPicture,
   // or paint a fresh one depending on what we intend to do with the
   // picture. For now we just paint a fresh one to get consistent results.
   if (!DrawsContent())
     return skia::RefPtr<SkPicture>();
 
   int width = bounds().width();
   int height = bounds().height();
   gfx::RectF opaque;
 
   skia::RefPtr<SkPicture> picture = skia::AdoptRef(new SkPicture);
   SkCanvas* canvas = picture->beginRecording(width, height);
   client_->PaintContents(canvas, gfx::Rect(width, height), &opaque);
   picture->endRecording();
   return picture;
 }
 
 void PictureLayer::RunMicroBenchmark(MicroBenchmark* benchmark) {
   benchmark->RunOnLayer(this);
 }
 
 }  // namespace cc