Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 2229013002: webrtc: use correct cwd for running tests (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/webrtc/api.py
diff --git a/scripts/slave/recipe_modules/webrtc/api.py b/scripts/slave/recipe_modules/webrtc/api.py
index efe4b62f8c561db9f694dd0712d15ad6eba30010..d6b333f18e54d979868af1cc5bbd25e69da2817c 100644
--- a/scripts/slave/recipe_modules/webrtc/api.py
+++ b/scripts/slave/recipe_modules/webrtc/api.py
@@ -13,6 +13,10 @@ class WebRTCApi(recipe_api.RecipeApi):
super(WebRTCApi, self).__init__(**kwargs)
self._env = {}
+ # Keep track of working directory (which contains the checkout).
+ # None means "default value".
+ self._working_dir = None
+
BUILDERS = builders.BUILDERS
RECIPE_CONFIGS = builders.RECIPE_CONFIGS
@@ -138,9 +142,9 @@ class WebRTCApi(recipe_api.RecipeApi):
self.m.platform.name).split('-', 1)[0])
def checkout(self, **kwargs):
- checkout_dir = self.m.chromium_tests.get_checkout_dir({})
- if checkout_dir:
- kwargs.setdefault('cwd', checkout_dir)
+ self._working_dir = self.m.chromium_tests.get_checkout_dir({})
+ if self._working_dir:
+ kwargs.setdefault('cwd', self._working_dir)
update_step = self.m.bot_update.ensure_checkout(**kwargs)
assert update_step.json.output['did_run']
@@ -177,31 +181,36 @@ class WebRTCApi(recipe_api.RecipeApi):
Args:
test_suite: The name of the test suite.
"""
- if self.c.use_isolate:
- self.m.isolate.remove_build_metadata()
- self.m.isolate.isolate_tests(self.m.chromium.output_dir,
- targets=self.NORMAL_TESTS)
-
- tests = steps.generate_tests(self, self.c.TEST_SUITE, self.revision,
- self.c.enable_swarming)
- with self.m.step.defer_results():
- if tests:
- if self.m.chromium.c.TARGET_PLATFORM == 'android':
- self.m.chromium_android.common_tests_setup_steps()
-
+ context = {}
+ if self._working_dir:
+ context['cwd'] = self._working_dir
+
+ with self.m.step.context(context):
+ if self.c.use_isolate:
+ self.m.isolate.remove_build_metadata()
+ self.m.isolate.isolate_tests(self.m.chromium.output_dir,
+ targets=self.NORMAL_TESTS)
+
+ tests = steps.generate_tests(self, self.c.TEST_SUITE, self.revision,
+ self.c.enable_swarming)
+ with self.m.step.defer_results():
+ if tests:
+ if self.m.chromium.c.TARGET_PLATFORM == 'android':
+ self.m.chromium_android.common_tests_setup_steps()
+
+ for test in tests:
+ test.run(self, suffix='')
+
+ if self.m.chromium.c.TARGET_PLATFORM == 'android':
+ self.m.chromium_android.shutdown_device_monitor()
+ self.m.chromium_android.logcat_dump(gs_bucket='chromium-android')
+ self.m.chromium_android.stack_tool_steps(force_latest_version=True)
+ self.m.chromium_android.test_report()
+
+ with self.m.step.defer_results():
for test in tests:
- test.run(self, suffix='')
-
- if self.m.chromium.c.TARGET_PLATFORM == 'android':
- self.m.chromium_android.shutdown_device_monitor()
- self.m.chromium_android.logcat_dump(gs_bucket='chromium-android')
- self.m.chromium_android.stack_tool_steps(force_latest_version=True)
- self.m.chromium_android.test_report()
-
- with self.m.step.defer_results():
- for test in tests:
- if test.enable_swarming:
- self.m.swarming.collect_task(test.swarming_task)
+ if test.enable_swarming:
+ self.m.swarming.collect_task(test.swarming_task)
def add_test(self, test, name=None, args=None, revision=None, env=None,
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698