tools/gn/command_gen.cc - Issue 22290010: Add support for data deps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_gen.cc

Issue 22290010: Add support for data deps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove switch Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_gen.cc

diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc

index 5f89764ec8af18d6310b5410cf54ae4f780562ab..7d8203d267f643bfe40a9b1397aee5f2e490baad 100644

--- a/tools/gn/command_gen.cc

+++ b/tools/gn/command_gen.cc

@@ -58,11 +58,8 @@ int RunGen(const std::vector<std::string>& args) {

return 1;

// Write the root ninja files.

- if (!NinjaWriter::RunAndWriteFiles(&setup->build_settings())) {

- Err(Location(),

- "Couldn't open root buildfile(s) for writing").PrintToStdout();

+ if (!NinjaWriter::RunAndWriteFiles(&setup->build_settings()))

return 1;

- }

base::TimeTicks end_time = base::TimeTicks::Now();

« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/command_help.cc » ('j') | no next file with comments »