Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: device/bluetooth/bluetooth_device_win.cc

Issue 2228953003: bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: TIL value_or Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_device_win.h ('k') | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_device_win.cc
diff --git a/device/bluetooth/bluetooth_device_win.cc b/device/bluetooth/bluetooth_device_win.cc
index f71c1372891f7d474ddd2445d8b630cc132aa9f0..9436651ccbc9a86a86a5a290ae35dc6b5f206f07 100644
--- a/device/bluetooth/bluetooth_device_win.cc
+++ b/device/bluetooth/bluetooth_device_win.cc
@@ -116,13 +116,16 @@ BluetoothDevice::UUIDList BluetoothDeviceWin::GetUUIDs() const {
return uuids_;
}
-int16_t BluetoothDeviceWin::GetInquiryRSSI() const {
- return kUnknownPower;
+base::Optional<int8_t> BluetoothDeviceWin::GetInquiryRSSI() const {
+ // In windows, we can only get connected devices and connected
+ // devices don't have an Inquiry RSSI.
+ return base::nullopt;
}
-int16_t BluetoothDeviceWin::GetInquiryTxPower() const {
- NOTIMPLEMENTED();
- return kUnknownPower;
+base::Optional<int8_t> BluetoothDeviceWin::GetInquiryTxPower() const {
+ // In windows, we can only get connected devices and connected
+ // devices don't have an Inquiry Tx Power.
+ return base::nullopt;
}
bool BluetoothDeviceWin::ExpectingPinCode() const {
« no previous file with comments | « device/bluetooth/bluetooth_device_win.h ('k') | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698