Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2228933002: Use elementAfter/Before, not nodeAfter/Before for nth-invalidation. (Closed)

Created:
4 years, 4 months ago by rune
Modified:
4 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use elementAfter/Before, not nodeAfter/Before for nth-invalidation. If the node after/before the inserted element is a text node, and that text node is the last/first sibling, then it shouldn't prevent the optimization for skipping recalc for nth/nth-last selectors. R=esprehn@chromium.org Committed: https://crrev.com/44689f753396097291572e2f2f7f69fd2fdb38f4 Cr-Commit-Position: refs/heads/master@{#410758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/nth-pseudo.html View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rune
ptal working on a CL to use invalidations sets for :nth*, btw.
4 years, 4 months ago (2016-08-09 18:38:45 UTC) #9
esprehn
lgtm
4 years, 4 months ago (2016-08-09 18:49:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228933002/1
4 years, 4 months ago (2016-08-09 18:50:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 18:54:44 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:57:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44689f753396097291572e2f2f7f69fd2fdb38f4
Cr-Commit-Position: refs/heads/master@{#410758}

Powered by Google App Engine
This is Rietveld 408576698