Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 222893002: MIPS: Make invalid LHSs that are calls late errors. (Closed)

Created:
6 years, 8 months ago by palfia
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Make invalid LHSs that are calls late errors. Port r20428 (7a071766) Original commit message: Necessary for web legacy compatibility. Also fold in additional strict mode checks into LHS checks. Minor constness clean-ups on the way. BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/mips/full-codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
6 years, 8 months ago (2014-04-02 20:17:04 UTC) #1
rossberg
lgtm
6 years, 8 months ago (2014-04-02 21:05:33 UTC) #2
palfia
6 years, 8 months ago (2014-04-02 22:17:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698