simplify the bazel-provider to use a search path appraoch

simplify the bazel-provider to use a search path appraoch

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/9968b369b914e57f0733a645714f9f6f7d7fa5f5

[Siggi Cherem (dart-lang), 2016-08-09 23:52:14]

sigmund@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-08-09 23:58:47]

lgtm

https://codereview.chromium.org/2228913004/diff/1/pkg/compiler/lib/src/source...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/2228913004/diff/1/pkg/compiler/lib/src/source...
pkg/compiler/lib/src/source_file_provider.dart:386: : dirs =
searchPaths.split(',').map(_resolve).toList();
why not just provide the search path directly as a list of strings?

[Siggi Cherem (dart-lang), 2016-08-10 15:52:15]

thanks harry, I also renamed the flag to --bazel-paths since it's no longer a
config file.

https://codereview.chromium.org/2228913004/diff/1/pkg/compiler/lib/src/source...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/2228913004/diff/1/pkg/compiler/lib/src/source...
pkg/compiler/lib/src/source_file_provider.dart:386: : dirs =
searchPaths.split(',').map(_resolve).toList();
On 2016/08/09 23:58:46, Harry Terkelsen wrote:
> why not just provide the search path directly as a list of strings?

good idea - done.

[Siggi Cherem (dart-lang), 2016-08-10 16:57:50]

Description was changed from

==========
simplify the bazel-provider to use a search path appraoch
==========

to

==========
simplify the bazel-provider to use a search path appraoch

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9968b369b914e57f0733a645714f9f6f7d7fa5f5
==========

[Siggi Cherem (dart-lang), 2016-08-10 16:57:53]

Committed patchset #2 (id:20001) manually as
9968b369b914e57f0733a645714f9f6f7d7fa5f5 (presubmit successful).