Move part of browsing data counter text util method to components

chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_counter_utils.h"
 
 #include <string>
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
@@ skipping 59 matching lines @@
         test_case.num_addresses);
 
     SCOPED_TRACE(base::StringPrintf(
         "Test params: %d credit card(s), "
             "%d address(es), %d suggestion(s).",
         test_case.num_credit_cards,
         test_case.num_addresses,
         test_case.num_suggestions
     ));
 
-    base::string16 output = GetCounterTextFromResult(&result);
+    base::string16 output = GetChromeCounterTextFromResult(&result);

[msramek, 2016/08/09 16:28:32]

The autofill-related functionality now lives in GetCounterTextFromResult(). So
this should be changed back and instead, this entire test should be moved to
//components.

[ioanap, 2016/08/10 09:34:37]

Done.

[msramek, 2016/08/10 09:59:50]

Just for the record - for maximum pedantness, this whole file should be only
compiled if ENABLE_EXTENSIONS are defined, since that is the only functionality
left. But I think that would make things very confusing as
browsing_data_counter_utils.cc is compiled always, so let's just leave it as it
is.

[ioanap, 2016/08/10 11:12:32]

Acknowledged. Thank you!

     EXPECT_EQ(output, base::ASCIIToUTF16(test_case.expected_output));
   }
 }
 
 #if defined(ENABLE_EXTENSIONS)
 // Tests the complex output of the hosted apps counter.
 TEST_F(BrowsingDataCounterUtilsTest, HostedAppsCounterResult) {
   HostedAppsCounter counter(GetProfile());
 
   // This test assumes that the strings are served exactly as defined,
@@ skipping 22 matching lines @@
     // The first two apps in the list are used as examples.
     std::vector<std::string> examples;
     examples.assign(
         apps.begin(), apps.begin() + (apps.size() > 2 ? 2 : apps.size()));
 
     HostedAppsCounter::HostedAppsResult result(
         &counter,
         apps.size(),
         examples);
 
-    base::string16 output = GetCounterTextFromResult(&result);
+    base::string16 output = GetChromeCounterTextFromResult(&result);
     EXPECT_EQ(output, base::ASCIIToUTF16(test_case.expected_output));
   }
 }
 #endif