Added an origin trial for WebShare.

Added an origin trial for WebShare.

This allows sites to register for a token to use navigator.share for a
limited time (for API experimentation purposes only).

BUG=635805
Committed: https://crrev.com/0f782e18ab076cd108a9a63a12a97c4703f125f0
Cr-Commit-Position: refs/heads/master@{#416179}

[Matt Giuca, 2016-08-10 09:19:53]

mgiuca@chromium.org changed reviewers:
+ esprehn@chromium.org

[Matt Giuca, 2016-08-10 09:19:54]

Hi Elliott,

Adding an origin trial, hopefully for M54 (though we may let it slip since I
think we have to have this done by feature freeze).

Potential blockers:
- Intent to experiment is in draft form (this time, we will wait until that is
sent out before landing this, but I want to do the review in parallel).
- UMA is in another CL: https://codereview.chromium.org/2234723002/
- Finch killswitch TODO.

[esprehn, 2016-08-10 09:35:58]

https://codereview.chromium.org/2228873002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right):

https://codereview.chromium.org/2228873002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:841: if
(!originTrialContext->featureBindingsInstalled("WebShare") &&
(RuntimeEnabledFeatures::webBluetoothEnabled() ||
originTrialContext->isFeatureEnabled("WebShare"))) {
The Bluetooth check here looks like a mistake?

[Matt Giuca, 2016-08-11 03:08:41]

https://codereview.chromium.org/2228873002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right):

https://codereview.chromium.org/2228873002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:841: if
(!originTrialContext->featureBindingsInstalled("WebShare") &&
(RuntimeEnabledFeatures::webBluetoothEnabled() ||
originTrialContext->isFeatureEnabled("WebShare"))) {
On 2016/08/10 09:35:57, esprehn wrote:
> The Bluetooth check here looks like a mistake?

Ahaha yes. (Although it "happens" to work because both our flag and Bluetooth
are linked to the experimental flag).

[Matt Giuca, 2016-08-11 03:08:52]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 03:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-11 03:09:44]

lgtm

[commit-bot: I haz the power, 2016-08-11 07:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 07:04:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Matt Giuca, 2016-08-16 01:06:32]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-08-16 01:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-08-16 01:06:57]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2016-09-02 01:44:49]

On 2016/08/16 01:06:51, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Intent to experiment has 3 LGTMs:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zuqQaLp3js8

[Matt Giuca, 2016-09-02 01:45:30]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-09-02 01:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2228873002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-09-02 01:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-09-02 03:20:00]

LGTM

[commit-bot: I haz the power, 2016-09-02 03:30:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 03:34:07]

Description was changed from

==========
Added an origin trial for WebShare.

This allows sites to register for a token to use navigator.share for a
limited time (for API experimentation purposes only).

BUG=635805
==========

to

==========
Added an origin trial for WebShare.

This allows sites to register for a token to use navigator.share for a
limited time (for API experimentation purposes only).

BUG=635805

Committed: https://crrev.com/0f782e18ab076cd108a9a63a12a97c4703f125f0
Cr-Commit-Position: refs/heads/master@{#416179}
==========

[commit-bot: I haz the power, 2016-09-02 03:34:09]

Patchset 3 (id:??) landed as
https://crrev.com/0f782e18ab076cd108a9a63a12a97c4703f125f0
Cr-Commit-Position: refs/heads/master@{#416179}