Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2228843003: [LayoutNG] Change core/layout/ng to Chromium style and rename files. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
Gleb Lanbin, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Change core/layout/ng to Chromium style and rename files. underscore case will mean this skips the CheckWebkitStyle test in the presubmit. BUG=635619 Committed: https://crrev.com/79c47e69b04edb124fe285223615508f6761ae1b Cr-Commit-Position: refs/heads/master@{#410916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -635 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/layout/ng/LayoutNGBlockFlow.h View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/LayoutNGBlockFlow.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.h View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGFragment.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGFragment.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGMarginStrut.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGText.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGText.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/NGUnits.h View 1 chunk +0 lines, -46 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.h View 1 chunk +7 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +154 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_fragment.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_margin_strut.h View 1 chunk +6 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_text.h View 1 chunk +39 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_text.cc View 1 chunk +6 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
ikilpatrick
4 years, 4 months ago (2016-08-09 21:38:44 UTC) #3
eae
LGTM as per discussion on blink-dev
4 years, 4 months ago (2016-08-09 21:42:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228843003/1
4 years, 4 months ago (2016-08-09 22:18:24 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 01:50:54 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 01:52:39 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c47e69b04edb124fe285223615508f6761ae1b
Cr-Commit-Position: refs/heads/master@{#410916}

Powered by Google App Engine
This is Rietveld 408576698