ui/views/controls/textfield/textfield_model.h - Issue 2228833002: MacViews: Fix behavior of move and select commands when selection direction changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield_model.h

Issue 2228833002: MacViews: Fix behavior of move and select commands when selection direction changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_text_commands

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield_model.h

diff --git a/ui/views/controls/textfield/textfield_model.h b/ui/views/controls/textfield/textfield_model.h

index 88a07b17e8ea8129a250da96f292d447dd4d4f2e..c66fe6d068083ee7047790207da919042160e663 100644

--- a/ui/views/controls/textfield/textfield_model.h

+++ b/ui/views/controls/textfield/textfield_model.h

@@ -120,7 +120,7 @@ class VIEWS_EXPORT TextfieldModel {

// The current composition text will be confirmed.

void MoveCursor(gfx::BreakType break_type,

gfx::VisualCursorDirection direction,

- bool select);

+ gfx::SelectionBehavior selection_behavior);

// Updates the cursor to the specified selection model. Any composition text

// will be confirmed, which may alter the specified selection range start.

« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/controls/textfield/textfield_model.cc » ('j') | no next file with comments »