MacViews: Fix behavior of move and select commands when selection direction changes.

ui/gfx/text_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_TEXT_CONSTANTS_H_
 #define UI_GFX_TEXT_CONSTANTS_H_
 
 namespace gfx {
 
 // TODO(msw): Distinguish between logical character stops and glyph stops?
 // TODO(msw): Merge with base::i18n::BreakIterator::BreakType.
 enum BreakType {
   CHARACTER_BREAK = 0, // Stop cursor movement on neighboring characters.
   WORD_BREAK,          // Stop cursor movement on nearest word boundaries.
   LINE_BREAK,          // Stop cursor movement on line ends as shown on screen.
 };
 
+// Specifies the selection behavior for a move/move-and-select command. For
+// example consider the state "ab|cd|e", i.e. cd is selected. Assume the
+// selection direction is from left to right. If we move to the beginning of the
+// line, the resultant state is:
+// "|ab|cde" for SELECTION_START_NEW, selection direction from right to left.

[tapted, 2016/08/16 03:28:31]

update wrt START_NEW?

[karandeepb, 2016/08/16 10:24:52]

Done.

+// "|abcd|e" for SELECTION_EXTEND, selection direction from right to left.
+// "ab|cde" for SELECTION_CARET.
+// "|abcde" for SELECTION_NONE.
+enum SelectionBehavior {
+  // Default behavior for a move-and-select command. The selection start point
+  // remains the same. For example, this is the behavior of textfields on Mac
+  // for the command moveUpAndModifySelection (Shift + Up).
+  SELECTION_DEFAULT,

[tapted, 2016/08/16 03:28:31]

maybe SELECTION_RETAIN? -- seems like a better balance to SELECTION_NONE

[karandeepb, 2016/08/16 10:24:52]

Done.

+
+  // Use for move-and-select commands which want the existing selection to be
+  // extended in the opposite direction, when the selection direction is
+  // reversed. For example, this is the behavior for textfields on Mac for the
+  // command moveToLeftEndOfLineAndModifySelection (Command + Shift + Left).
+  SELECTION_EXTEND,
+
+  // Use for move-and-select commands which want the existing selection to
+  // reduce to a caret, when the selection direction is reversed. For example,
+  // this is the behavior for textfields on Mac for the command
+  // moveWordLeftAndModifySelection (Alt + Shift + Left).
+  SELECTION_CARET,
+
+  // No selection. To be used for move commands, which don't want to cause a
+  // selection.
+  SELECTION_NONE,
+};
+
 // Specifies the word wrapping behavior when a word would exceed the available
 // display width. All words that are too wide will be put on a new line, and
 // then:
 enum WordWrapBehavior {
   IGNORE_LONG_WORDS,   // Overflowing word text is left on that line.
   TRUNCATE_LONG_WORDS, // Overflowing word text is truncated.
   ELIDE_LONG_WORDS,    // Overflowing word text is elided at the ellipsis.
   WRAP_LONG_WORDS,     // Overflowing word text is wrapped over multiple lines.
 };
 
@@ skipping 49 matching lines @@
   ELIDE_HEAD,   // Add an ellipsis at the start of the string.
   ELIDE_MIDDLE, // Add an ellipsis in the middle of the string.
   ELIDE_TAIL,   // Add an ellipsis at the end of the string.
   ELIDE_EMAIL,  // Add ellipses to username and domain substrings.
   FADE_TAIL,    // Fade the string's end opposite of its horizontal alignment.
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_TEXT_CONSTANTS_H_