Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: build/check_return_value.py

Issue 222883002: check_return_value.py should drop stderr of the command it runs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_return_value.py
diff --git a/build/check_return_value.py b/build/check_return_value.py
index 6f0daec3a751bdf4f043274f1196193929b5dd4b..c659d1e9674ab96af49c3fb2dea8b061ecef162a 100755
--- a/build/check_return_value.py
+++ b/build/check_return_value.py
@@ -6,10 +6,12 @@
"""This program wraps an arbitrary command and prints "1" if the command ran
successfully."""
+import os
import subprocess
import sys
-if not subprocess.call(sys.argv[1:]):
+devnull = open(os.devnull, 'wb')
+if not subprocess.call(sys.argv[1:], stdout=devnull, stderr=devnull):
print 1
else:
print 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698