chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h - Issue 2228823003: When possible, draw the toolbar shadow with the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

Issue 2228823003: When possible, draw the toolbar shadow with the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/layer/toolbar_layer.cc ('k') | chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

diff --git a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

index 112bc7c03efa38df8263819dd719b65cdee08950..946bb8a69d36b70d179e9f6474cc3f06eb02cec2 100644

--- a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

+++ b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

@@ -54,6 +54,7 @@ class TabListSceneLayer : public SceneLayer {

const base::android::JavaParamRef<jobject>& jobj,

jint id,

jint toolbar_resource_id,

+ jint toolbar_shadow_resource_id,

jint close_button_resource_id,

jint shadow_resource_id,

jint contour_resource_id,

@@ -103,7 +104,8 @@ class TabListSceneLayer : public SceneLayer {

jfloat toolbar_y_offset,

jfloat side_border_scale,

jboolean attach_content,

- jboolean inset_border);

+ jboolean inset_border,

+ jboolean needs_toolbar_shadow);

base::android::ScopedJavaLocalRef<jobject> GetJavaObject(JNIEnv* env);