chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java - Issue 2228823003: When possible, draw the toolbar shadow with the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

Issue 2228823003: When possible, draw the toolbar shadow with the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

index 2cb5801850d51349173061361a29cf01e32aa950..bd89367e2b53a01f138ca8b10c7f54236172bee3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

@@ -542,6 +542,14 @@ public class ChromeFullscreenManager

scheduleVisibilityUpdate();

}

+ /**

+ * @return True if the Android version of the top controls are hidden. This includes cases

+ * where the controls offset is < 0;

+ */

+ public boolean isTopControlsAndroidViewHidden() {

+ return mTopControlsAndroidViewHidden || getControlOffset() < 0;

+ }

private boolean shouldShowAndroidControls() {

if (mTopControlsAndroidViewHidden) return false;