| Index: components/offline_pages/background/request_queue_unittest.cc
|
| diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
|
| index 967257c6d83c047573e7cac7a124d32bf3fc7125..8d948c1d23606679d5d99feba0d5ae1cc713d1a4 100644
|
| --- a/components/offline_pages/background/request_queue_unittest.cc
|
| +++ b/components/offline_pages/background/request_queue_unittest.cc
|
| @@ -162,8 +162,10 @@ TEST_F(RequestQueueTest, RemoveRequest) {
|
| PumpLoop();
|
| ASSERT_EQ(kRequestId, last_added_request()->request_id());
|
|
|
| - queue()->RemoveRequest(
|
| - kRequestId,
|
| + std::vector<int64_t> remove_requests;
|
| + remove_requests.push_back(kRequestId);
|
| + queue()->RemoveRequests(
|
| + remove_requests,
|
| base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
|
| PumpLoop();
|
| ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
|
| @@ -175,43 +177,6 @@ TEST_F(RequestQueueTest, RemoveRequest) {
|
| ASSERT_EQ(0ul, last_requests().size());
|
| }
|
|
|
| -TEST_F(RequestQueueTest, RemoveRequestByClientId) {
|
| - base::Time creation_time = base::Time::Now();
|
| - // Put two requests on the queue with different client IDs.
|
| - SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
|
| - kUserRequested);
|
| - queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
|
| - base::Unretained(this)));
|
| - SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time,
|
| - kUserRequested);
|
| - queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
|
| - base::Unretained(this)));
|
| - PumpLoop();
|
| -
|
| - queue()->GetRequests(
|
| - base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
|
| - PumpLoop();
|
| - ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
|
| - ASSERT_EQ(2ul, last_requests().size());
|
| -
|
| - std::vector<ClientId> client_ids;
|
| - client_ids.push_back(kClientId);
|
| -
|
| - // Removing the first client ID should leave only the second on the queue.
|
| - queue()->RemoveRequestsByClientId(
|
| - client_ids,
|
| - base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
|
| - PumpLoop();
|
| - ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
|
| -
|
| - queue()->GetRequests(
|
| - base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
|
| - PumpLoop();
|
| - ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
|
| - ASSERT_EQ(1ul, last_requests().size());
|
| - ASSERT_EQ(kClientId2, last_requests().front().client_id());
|
| -}
|
| -
|
| // A longer test populating the request queue with more than one item, properly
|
| // listing multiple items and removing the right item.
|
| TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) {
|
| @@ -235,8 +200,10 @@ TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) {
|
| ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
|
| ASSERT_EQ(2ul, last_requests().size());
|
|
|
| - queue()->RemoveRequest(
|
| - request1.request_id(),
|
| + std::vector<int64_t> remove_requests;
|
| + remove_requests.push_back(request1.request_id());
|
| + queue()->RemoveRequests(
|
| + remove_requests,
|
| base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
|
| PumpLoop();
|
| ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
|
|
|