Changes to fit better with the needs of the download manager.

components/offline_pages/background/request_queue.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 56 matching lines @@
   // appropriate result. Callback will also return a copy of a request with all
   // fields set.
   void AddRequest(const SavePageRequest& request,
                   const AddRequestCallback& callback);
 
   // Updates a request in the request queue if a request with matching ID
   // exists. Does nothing otherwise. Result is returned through |callback|.
   void UpdateRequest(const SavePageRequest& request,
                      const UpdateRequestCallback& callback);
 
-  // Removes the request matching the |request_id|. Result is returned through
+  // Removes the requests matching the |request_ids|. Result is returned through

[Dmitry Titov, 2016/08/10 02:52:14]

This returns result from UpdateRequestResult. That enum assumes one request. Now
that there are many, perhaps enum should be changed and comment updated for
partial success/failure, as in: *some* ids did not map to existing requests.
Also, in that case we should wither delete all that do map, or don't delete
enything. 

[Pete Williamson, 2016/08/10 21:15:25]

OK, changed the callback to return an array of statuses (along with a matching
array of request ids) so the client can tell what didn't get removed, if they
care.  The client will also be getting notifications eventually for items that
do get removed.

   // |callback|.
-  void RemoveRequest(int64_t request_id, const UpdateRequestCallback& callback);
-
-  // Removes the requests matching the |client_ids|. Results are returned
-  // through |callback|.
-  void RemoveRequestsByClientId(const std::vector<ClientId>& client_id,
-                                const UpdateRequestCallback& callback);
+  void RemoveRequests(const std::vector<int64_t>& request_ids,
+                      const UpdateRequestCallback& callback);
 
   void GetForUpdateDone(
       const RequestQueue::UpdateRequestCallback& update_callback,
       const SavePageRequest& update_request,
       bool success,
       const std::vector<SavePageRequest>& requests);
 
  private:
   // Callback used by |PurgeRequests|.
   typedef base::Callback<void(UpdateRequestResult,
                               int /* removed requests count */)>
       PurgeRequestsCallback;
 
   // Purges the queue, removing the requests that are no longer relevant, e.g.
   // expired request. Result is returned through |callback| carries the number
   // of removed requests.
   void PurgeRequests(const PurgeRequestsCallback& callback);
 
   std::unique_ptr<RequestQueueStore> store_;
 
   // Allows us to pass a weak pointer to callbacks.
   base::WeakPtrFactory<RequestQueue> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestQueue);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_