Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 2228803003: There's no class A break point before or after a float. (Closed)

Created:
4 years, 4 months ago by mstensho (USE GERRIT)
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

There's no class A break point before or after a float. LayoutBox::classABreakPointValue() should only be called at class A break points. Document the assertion there, and make sure that needsForcedBreakBefore() only calls it when at in-flow objects. BUG=619152 R=eae@chromium.org Committed: https://crrev.com/194b775563c7c3ecff9ba92187aa7ca3d330b303 Cr-Commit-Position: refs/heads/master@{#410703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/balance-float-after-forced-break.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/balance-float-after-forced-break-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
4 years, 4 months ago (2016-08-09 10:40:02 UTC) #1
eae
LGTM Welcome back, we missed you!
4 years, 4 months ago (2016-08-09 13:38:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228803003/1
4 years, 4 months ago (2016-08-09 14:10:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/206499) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 14:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228803003/1
4 years, 4 months ago (2016-08-09 14:47:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 16:44:56 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:46:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/194b775563c7c3ecff9ba92187aa7ca3d330b303
Cr-Commit-Position: refs/heads/master@{#410703}

Powered by Google App Engine
This is Rietveld 408576698