Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2228803002:
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error (Closed)
DescriptionFix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Patch Set 1 #
Messages
Total messages: 13 (7 generated)
Description was changed from
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
==========
to
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
to
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
to
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
Message was sent while issue was closed.
robliao@chromium.org changed reviewers: + kylechar@chromium.org, piman@chromium.org, sievers@chromium.org
Message was sent while issue was closed.
Description was changed from
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
to
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/07f76b56d97ff6f99263d5dd61c02aba7667d458
Cr-Commit-Position: refs/heads/master@{#410518}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/07f76b56d97ff6f99263d5dd61c02aba7667d458 Cr-Commit-Position: refs/heads/master@{#410518}
Message was sent while issue was closed.
Description was changed from
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/07f76b56d97ff6f99263d5dd61c02aba7667d458
Cr-Commit-Position: refs/heads/master@{#410518}
==========
to
==========
Fix ui/gl/BUILD.gn include_dirs Nonempty List Replacement Error
This change fixes this error:
ERROR at //ui/gl/BUILD.gn:236:7: Replacing nonempty list.
include_dirs = [ "//third_party/swiftshader/include" ]
^-----------
This overwrites a previously-defined nonempty list (length 1).
See //ui/gl/BUILD.gn:132:18: for previous definition
include_dirs = [ "//third_party/mesa/src/include" ]
^----------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
foo = []
before reassigning.
See //BUILD.gn:298:7: which caused the file to be included.
"//ui/gl:gl_unittests",
^---------------------
BUG=635702
TBR=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========
Message was sent while issue was closed.
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
