Fix memory corruption from SetMaxPacingRate by inlining PacingSender.

net/quic/core/congestion_control/pacing_sender_test.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/congestion_control/pacing_sender.h"
 
 #include <memory>
 
 #include "base/logging.h"
 #include "net/quic/core/quic_protocol.h"
@@ skipping 11 matching lines @@
 const QuicByteCount kBytesInFlight = 1024;
 const int kInitialBurstPackets = 10;
 
 class PacingSenderTest : public ::testing::Test {
  protected:
   PacingSenderTest()
       : zero_time_(QuicTime::Delta::Zero()),
         infinite_time_(QuicTime::Delta::Infinite()),
         packet_number_(1),
         mock_sender_(new StrictMock<MockSendAlgorithm>()),
-        pacing_sender_(new PacingSender(mock_sender_,
-                                        QuicTime::Delta::FromMilliseconds(1),
-                                        0)) {
+        pacing_sender_(new PacingSender) {
+    pacing_sender_->set_sender(mock_sender_.get());
     // Pick arbitrary time.
     clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(9));
   }
 
   ~PacingSenderTest() override {}
 
   void InitPacingRate(QuicPacketCount burst_size, QuicBandwidth bandwidth) {
-    pacing_sender_.reset();
-    mock_sender_ = new StrictMock<MockSendAlgorithm>();
-    pacing_sender_.reset(new PacingSender(
-        mock_sender_, QuicTime::Delta::FromMilliseconds(1), burst_size));
+    mock_sender_.reset(new StrictMock<MockSendAlgorithm>());
+    pacing_sender_.reset(new PacingSender);
+    pacing_sender_->set_sender(mock_sender_.get());
     EXPECT_CALL(*mock_sender_, PacingRate(_)).WillRepeatedly(Return(bandwidth));
+    if (burst_size == 0) {
+      EXPECT_CALL(*mock_sender_, OnCongestionEvent(_, _, _, _));
+      SendAlgorithmInterface::CongestionVector lost_packets;
+      lost_packets.push_back(std::make_pair(1, kMaxPacketSize));
+      SendAlgorithmInterface::CongestionVector empty;
+      pacing_sender_->OnCongestionEvent(true, 1234, empty, lost_packets);
+    } else if (burst_size != kInitialBurstPackets) {
+      LOG(FATAL) << "Unsupported burst_size " << burst_size
+                 << " specificied, only 0 and " << kInitialBurstPackets
+                 << " are supported.";
+    }
   }
 
   void CheckPacketIsSentImmediately(HasRetransmittableData retransmittable_data,
                                     QuicByteCount bytes_in_flight,
                                     bool in_recovery) {
     // In order for the packet to be sendable, the underlying sender must
     // permit it to be sent immediately.
     for (int i = 0; i < 2; ++i) {
       EXPECT_CALL(*mock_sender_, TimeUntilSend(clock_.Now(), bytes_in_flight))
           .WillOnce(Return(zero_time_));
@@ skipping 36 matching lines @@
     EXPECT_CALL(*mock_sender_, OnCongestionEvent(true, kBytesInFlight, _, _));
     SendAlgorithmInterface::CongestionVector empty_map;
     pacing_sender_->OnCongestionEvent(true, kBytesInFlight, empty_map,
                                       empty_map);
   }
 
   const QuicTime::Delta zero_time_;
   const QuicTime::Delta infinite_time_;
   MockClock clock_;
   QuicPacketNumber packet_number_;
-  StrictMock<MockSendAlgorithm>* mock_sender_;
+  std::unique_ptr<StrictMock<MockSendAlgorithm>> mock_sender_;
   std::unique_ptr<PacingSender> pacing_sender_;
 };
 
 TEST_F(PacingSenderTest, NoSend) {
   for (int i = 0; i < 2; ++i) {
     EXPECT_CALL(*mock_sender_, TimeUntilSend(clock_.Now(), kBytesInFlight))
         .WillOnce(Return(infinite_time_));
     EXPECT_EQ(infinite_time_,
               pacing_sender_->TimeUntilSend(clock_.Now(), kBytesInFlight));
   }
@@ skipping 215 matching lines @@
                         kMaxPacketSize, QuicTime::Delta::FromMilliseconds(1)));
 
   UpdateRtt();
 
   // Ensure only one packet is sent immediately and the rest are paced.
   CheckPacketIsSentImmediately(HAS_RETRANSMITTABLE_DATA, 0, true);
   CheckPacketIsSentImmediately();
   CheckPacketIsDelayed(QuicTime::Delta::FromMilliseconds(2));
 }
 
-TEST_F(PacingSenderTest, VerifyInnerSenderCalled) {
-  QuicBandwidth kBandwidth = QuicBandwidth::FromBitsPerSecond(1000);
-  QuicTime kTime = QuicTime::Infinite();
-  QuicTime::Delta kTimeDelta = QuicTime::Delta::Infinite();
-  QuicByteCount kBytes = 12345u;
-
-  EXPECT_CALL(*mock_sender_, SetFromConfig(_, Perspective::IS_SERVER));
-  QuicConfig config;
-  pacing_sender_->SetFromConfig(config, Perspective::IS_SERVER);
-
-  EXPECT_CALL(*mock_sender_, ResumeConnectionState(_, true));
-  CachedNetworkParameters cached_network_params;
-  pacing_sender_->ResumeConnectionState(cached_network_params, true);
-
-  EXPECT_CALL(*mock_sender_, SetNumEmulatedConnections(2));
-  pacing_sender_->SetNumEmulatedConnections(2);
-
-  SendAlgorithmInterface::CongestionVector packets;
-  EXPECT_CALL(*mock_sender_, OnCongestionEvent(true, kBytes, packets, packets));
-  pacing_sender_->OnCongestionEvent(true, kBytes, packets, packets);
-
-  EXPECT_CALL(*mock_sender_, OnPacketSent(kTime, kBytes, 123u, kBytes,
-                                          HAS_RETRANSMITTABLE_DATA));
-  EXPECT_CALL(*mock_sender_, PacingRate(_)).WillOnce(Return(kBandwidth));
-  pacing_sender_->OnPacketSent(kTime, kBytes, 123u, kBytes,
-                               HAS_RETRANSMITTABLE_DATA);
-
-  EXPECT_CALL(*mock_sender_, OnRetransmissionTimeout(true));
-  pacing_sender_->OnRetransmissionTimeout(true);
-
-  EXPECT_CALL(*mock_sender_, OnConnectionMigration());
-  pacing_sender_->OnConnectionMigration();
-
-  EXPECT_CALL(*mock_sender_, TimeUntilSend(kTime, kBytes))
-      .WillOnce(Return(kTimeDelta));
-  pacing_sender_->TimeUntilSend(kTime, kBytes);
-
-  EXPECT_CALL(*mock_sender_, PacingRate(_)).WillOnce(Return(kBandwidth));
-  EXPECT_EQ(kBandwidth, pacing_sender_->PacingRate(0));
-
-  EXPECT_CALL(*mock_sender_, BandwidthEstimate()).WillOnce(Return(kBandwidth));
-  EXPECT_EQ(kBandwidth, pacing_sender_->BandwidthEstimate());
-
-  EXPECT_CALL(*mock_sender_, RetransmissionDelay())
-      .WillOnce(Return(kTimeDelta));
-  EXPECT_EQ(kTimeDelta, pacing_sender_->RetransmissionDelay());
-
-  EXPECT_CALL(*mock_sender_, GetCongestionWindow()).WillOnce(Return(kBytes));
-  EXPECT_EQ(kBytes, pacing_sender_->GetCongestionWindow());
-
-  EXPECT_CALL(*mock_sender_, InSlowStart()).WillOnce(Return(true));
-  EXPECT_TRUE(pacing_sender_->InSlowStart());
-
-  EXPECT_CALL(*mock_sender_, InRecovery()).WillOnce(Return(true));
-  EXPECT_TRUE(pacing_sender_->InRecovery());
-
-  EXPECT_CALL(*mock_sender_, GetSlowStartThreshold()).WillOnce(Return(kBytes));
-  EXPECT_EQ(kBytes, pacing_sender_->GetSlowStartThreshold());
-
-  EXPECT_CALL(*mock_sender_, GetCongestionControlType())
-      .WillOnce(Return(kReno));
-  EXPECT_EQ(kReno, pacing_sender_->GetCongestionControlType());
-}
-
 }  // namespace test
 }  // namespace net