Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2228783003: [turbofan] Fix typed lowering of JSConvertReceiver. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typed lowering of JSConvertReceiver. We lowered JSConvertReceiver using JSToObject, w/o connecting the JSToObject to the control chain (which is fine since that ToObject cannot throw). But then the lowering of the JSToObject would insert an IfSuccess, which is immediately dead, since it is not used. This was fine in a sense that it didn't seem to crash anything, but we now want to do more aggressive checking if IfSuccess/IfException nodes and so we need to fix this sloppyness in the lowerings. R=mstarzinger@chromium.org Committed: https://crrev.com/750202973b39d0c5c794478e394cf76f0e7d9d99 Cr-Commit-Position: refs/heads/master@{#38484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -96 lines) Patch
M src/compiler/js-operator.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 15 chunks +141 lines, -91 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-09 10:57:36 UTC) #1
Benedikt Meurer
Hey Michi, Here's the fix for JSConvertReceiver. Also fixes the operator properties for the JSConvertReceiver ...
4 years, 4 months ago (2016-08-09 10:58:12 UTC) #4
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-09 11:22:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228783003/1
4 years, 4 months ago (2016-08-09 11:25:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 11:27:41 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 11:28:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750202973b39d0c5c794478e394cf76f0e7d9d99
Cr-Commit-Position: refs/heads/master@{#38484}

Powered by Google App Engine
This is Rietveld 408576698