Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2228783002: [Remoting Android] Fix component build runtime error (Closed)

Created:
4 years, 4 months ago by Yuwei
Modified:
4 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Fix component build runtime error Component build has been turned on by default but the generated Android client doesn't work since the JNI shared library cannot be located. The issue is that turning on the component build flag will add a ".cr" suffix to the name of the library while we always load `remoting_client_jni` unconditionally. This CL adds fallback for loading `remoting_client_jni.cr` if `remoting_client_jni` can't be loaded. BUG=634375 Committed: https://crrev.com/fa2204311b7b12bf707b1f670ca6ebe3b1e26250 Cr-Commit-Position: refs/heads/master@{#410550}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer's Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Yuwei
ptal
4 years, 4 months ago (2016-08-09 00:40:54 UTC) #2
Lambros
lgtm https://codereview.chromium.org/2228783002/diff/1/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java (right): https://codereview.chromium.org/2228783002/diff/1/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java#newcode26 remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:26: private static final String JNI_LIB_NAME = "remoting_client_jni"; Maybe ...
4 years, 4 months ago (2016-08-09 00:51:54 UTC) #3
Yuwei
https://codereview.chromium.org/2228783002/diff/1/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java (right): https://codereview.chromium.org/2228783002/diff/1/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java#newcode26 remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:26: private static final String JNI_LIB_NAME = "remoting_client_jni"; On 2016/08/09 ...
4 years, 4 months ago (2016-08-09 00:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228783002/20001
4 years, 4 months ago (2016-08-09 00:58:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 02:44:22 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:47:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa2204311b7b12bf707b1f670ca6ebe3b1e26250
Cr-Commit-Position: refs/heads/master@{#410550}

Powered by Google App Engine
This is Rietveld 408576698