third_party/WebKit/Source/core/animation/TimingInput.cpp - Issue 2228773002: Remove AnimationEffectTimingProperties playbackRate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/TimingInput.cpp

Issue 2228773002: Remove AnimationEffectTimingProperties playbackRate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@idl-updates

Patch Set: Rebase and update devtools AnimationModel.js Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | third_party/WebKit/Source/core/animation/TimingInputTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/TimingInput.cpp

diff --git a/third_party/WebKit/Source/core/animation/TimingInput.cpp b/third_party/WebKit/Source/core/animation/TimingInput.cpp

index e8f197e2f1a884ccb0fb265d13875a5b08ecaceb..910a78b7c81f911843a9a89f7ae7f664d68a3ed9 100644

--- a/third_party/WebKit/Source/core/animation/TimingInput.cpp

+++ b/third_party/WebKit/Source/core/animation/TimingInput.cpp

@@ -130,7 +130,7 @@ bool TimingInput::convert(const KeyframeEffectOptions& timingInput, Timing& timi

if (!setIterationDuration(timingOutput, timingInput.duration(), exceptionState))

return false;

- setPlaybackRate(timingOutput, timingInput.playbackRate());

+ setPlaybackRate(timingOutput, 1.0);

alancutter (OOO until 2018) 2016/08/09 03:45:48 TODO remove Timing::playbackRate.

setPlaybackDirection(timingOutput, timingInput.direction());

if (!setTimingFunction(timingOutput, timingInput.easing(), document, exceptionState))