chrome/browser/extensions/shared_user_script_master.h - Issue 2228743002: Rework some UserScriptLoader logic in preparation to removing UserScript copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_user_script_master.h

Issue 2228743002: Rework some UserScriptLoader logic in preparation to removing UserScript copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix DCHECK Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/shared_user_script_master.h

diff --git a/chrome/browser/extensions/shared_user_script_master.h b/chrome/browser/extensions/shared_user_script_master.h

index b697829e98a6f82889a89ecfece5227373eb0bc9..5d2282b8549933460495ed8c3145fceb506a566d 100644

--- a/chrome/browser/extensions/shared_user_script_master.h

+++ b/chrome/browser/extensions/shared_user_script_master.h

@@ -45,7 +45,7 @@ class SharedUserScriptMaster : public ExtensionRegistryObserver {

// Gets an extension's scripts' metadata; i.e., gets a list of UserScript

// objects that contains script info, but not the contents of the scripts.

- const std::set<UserScript> GetScriptsMetadata(const Extension* extension);

+ const std::vector<UserScript> GetScriptsMetadata(const Extension* extension);

Devlin 2016/08/11 01:09:27 Nit: UserScriptList?

lazyboy 2016/08/11 01:51:06 Done.

// Script loader that handles loading contents of scripts into shared memory

// and notifying renderers of scripts in shared memory.

« no previous file with comments | « no previous file | chrome/browser/extensions/shared_user_script_master.cc » ('j') | extensions/browser/user_script_loader.h » ('J')