Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: extensions/browser/declarative_user_script_master.cc

Issue 2228743002: Rework some UserScriptLoader logic in preparation to removing UserScript copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/declarative_user_script_master.cc
diff --git a/extensions/browser/declarative_user_script_master.cc b/extensions/browser/declarative_user_script_master.cc
index 68fc0c6534319cc358c0a4709e464f6dae1c5f36..2f916d417c2cb75bbb39ae909be8cf43d0ee3b69 100644
--- a/extensions/browser/declarative_user_script_master.cc
+++ b/extensions/browser/declarative_user_script_master.cc
@@ -32,26 +32,25 @@ DeclarativeUserScriptMaster::~DeclarativeUserScriptMaster() {
}
void DeclarativeUserScriptMaster::AddScript(const UserScript& script) {
- std::set<UserScript> set;
- set.insert(script);
- loader_->AddScripts(set);
+ UserScriptList scripts;
+ scripts.push_back(script);
+ loader_->AddScripts(scripts);
Devlin 2016/08/09 23:28:54 loader_->AddScripts(UserScriptList(1, script)); ?
lazyboy 2016/08/10 00:03:41 Done.
}
-void DeclarativeUserScriptMaster::AddScripts(
- const std::set<UserScript>& scripts,
- int render_process_id,
- int render_view_id) {
+void DeclarativeUserScriptMaster::AddScripts(const UserScriptList& scripts,
+ int render_process_id,
+ int render_view_id) {
loader_->AddScripts(scripts, render_process_id, render_view_id);
}
void DeclarativeUserScriptMaster::RemoveScript(const UserScript& script) {
- std::set<UserScript> set;
- set.insert(script);
+ std::set<UserScriptIDPair> set;
+ set.insert(UserScriptIDPair(script.id(), script.host_id()));
loader_->RemoveScripts(set);
}
void DeclarativeUserScriptMaster::RemoveScripts(
- const std::set<UserScript>& scripts) {
+ const std::set<UserScriptIDPair>& scripts) {
loader_->RemoveScripts(scripts);
}

Powered by Google App Engine
This is Rietveld 408576698