Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2228733005: Convert fast/css/background-serialize.html test to testharness.js (Closed)

Created:
4 years, 4 months ago by MuVen
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, Srirama
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert fast/css/background-serialize.html test to testharness.js Cleaning fast/css/* tests to use testharness.js instead of js-test.js. This will enable to upstream these tests to web-platform-tests. Committed: https://crrev.com/cb48e0a4f360c8fc01b7ae0078bfb130d2d4b335 Cr-Commit-Position: refs/heads/master@{#410912}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -55 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/background-serialize.html View 1 1 chunk +23 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/background-serialize-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
MuVen
PTAL. Let me know if this approach is okay. Based on this i shall work ...
4 years, 4 months ago (2016-08-09 13:23:00 UTC) #6
MuVen
PTAL
4 years, 4 months ago (2016-08-09 13:24:54 UTC) #9
Srirama
LGTM, but please wait for Dirk's comments. Also try to group similar test cases from ...
4 years, 4 months ago (2016-08-09 13:34:45 UTC) #10
MuVen
PTAL. https://codereview.chromium.org/2228733005/diff/1/third_party/WebKit/LayoutTests/fast/css/background-serialize.html File third_party/WebKit/LayoutTests/fast/css/background-serialize.html (right): https://codereview.chromium.org/2228733005/diff/1/third_party/WebKit/LayoutTests/fast/css/background-serialize.html#newcode12 third_party/WebKit/LayoutTests/fast/css/background-serialize.html:12: assert_equals(test('.test { background: none; }'), '.test { background: ...
4 years, 4 months ago (2016-08-09 13:46:47 UTC) #11
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-09 22:55:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228733005/20001
4 years, 4 months ago (2016-08-10 00:21:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 01:37:04 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 01:38:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb48e0a4f360c8fc01b7ae0078bfb130d2d4b335
Cr-Commit-Position: refs/heads/master@{#410912}

Powered by Google App Engine
This is Rietveld 408576698