Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2228723003: Make sure thread pool has at least 1 worker. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make sure thread pool has at least 1 worker. When doing a 'git cl archive' if there are no branches other then master the command will crash with a 'ValueError: Number of processes must be at least 1' when attempting to create the thread pool. This Cl modifies the code to use the maximum of the changes and 1 as the number of threads to create so we have at least one thread to work with. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/99d3017946e02465e04c557e0c1b1201ada85a58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-09 17:43:50 UTC) #4
tandrii(chromium)
Perfect! LGTM
4 years, 4 months ago (2016-08-09 17:45:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228723003/1
4 years, 4 months ago (2016-08-09 17:46:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/99d3017946e02465e04c557e0c1b1201ada85a58
4 years, 4 months ago (2016-08-09 17:49:03 UTC) #11
Dirk Pranke
4 years, 4 months ago (2016-08-09 18:23:57 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698