Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2228693002: Color: Add cc accessors and unit tests (Closed)

Created:
4 years, 4 months ago by ccameron
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Color: Add cc accessors and unit tests Add the ability to look up the color space for a resource when it is locked for GL read. Add tests to ensure that color spaces are transferred correctly (they weren't). Add a test to ensure that overlay candidacy is transferred correctly as well. BUG=44872 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/024c8dbbb497a75c01abb813d61659663689ccaa Cr-Commit-Position: refs/heads/master@{#410934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M cc/resources/resource_provider.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ccameron
Small patch, mostly tests.
4 years, 4 months ago (2016-08-08 22:12:50 UTC) #3
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-08 22:17:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228693002/1
4 years, 4 months ago (2016-08-08 22:20:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/269323)
4 years, 4 months ago (2016-08-08 23:24:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228693002/1
4 years, 4 months ago (2016-08-09 21:12:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/258796)
4 years, 4 months ago (2016-08-10 00:46:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228693002/1
4 years, 4 months ago (2016-08-10 02:17:41 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 03:03:32 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 03:04:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/024c8dbbb497a75c01abb813d61659663689ccaa
Cr-Commit-Position: refs/heads/master@{#410934}

Powered by Google App Engine
This is Rietveld 408576698