Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2228663002: Mojo C++ bindings: make permissions service use STL string/vector types (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, haraken, jam, mlamouri+watch-blink_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make permissions service use STL string/vector types BUG=624136 Committed: https://crrev.com/f276f42daf5d0ccf0698fd6241944a3a8981cdac Cr-Commit-Position: refs/heads/master@{#411255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -57 lines) Patch
M content/browser/permissions/permission_service_impl.h View 1 chunk +9 lines, -8 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 10 chunks +22 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
mlamouri (slow - plz ping)
lgtm
4 years, 4 months ago (2016-08-09 11:19:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228663002/1
4 years, 4 months ago (2016-08-09 14:08:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/233824)
4 years, 4 months ago (2016-08-09 14:13:27 UTC) #10
Reilly Grant (use Gerrit)
pfeldman@, please review third_party/WebKit/public/BUILD.gn.
4 years, 4 months ago (2016-08-09 19:25:17 UTC) #12
pfeldman
lgtm
4 years, 4 months ago (2016-08-11 00:50:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228663002/1
4 years, 4 months ago (2016-08-11 00:57:25 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 03:58:33 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 04:00:24 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f276f42daf5d0ccf0698fd6241944a3a8981cdac
Cr-Commit-Position: refs/heads/master@{#411255}

Powered by Google App Engine
This is Rietveld 408576698