Adding Android specific behavior when overriding YouTube Flash embeds.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 1420 matching lines @@
     url_str.replace(index, 1, "?");
 
     // Replace all instances of ? (after the first) with &
     for (size_t pos = index + 1;
          (pos = url_str.find("?", pos)) != std::string::npos; pos += 1) {
       url_str.replace(pos, 1, "&");
     }
   }
 
   GURL corrected_url = GURL(url_str);
-
-  // We don't modify any URLs that contain the enablejsapi=1 parameter
-  // since the page may be interacting with the YouTube Flash player in
-  // Javascript and we don't want to break working content.
+  bool android_enablejsapi = false;
+  // Unless we're on an Android device, we don't modify any URLs that contain
+  // the enablejsapi=1 parameter since the page may be interacting with the
+  // YouTube Flash player in Javascript and we don't want to break working
+  // content. If we're on an Android device and the URL contains the
+  // enablejsapi=1 parameter, we do override the URL.
   if (corrected_url.query().find("enablejsapi=1") != std::string::npos) {
+#if defined(OS_ANDROID)
+    RecordYouTubeRewriteUMA(internal::SUCCESS_ENABLEJSAPI);
+    android_enablejsapi = true;
+#else
     RecordYouTubeRewriteUMA(internal::FAILURE_ENABLEJSAPI);
     return GURL();
+#endif

[mlamouri (slow - plz ping), 2016/08/08 19:50:25]

I think this would be more readable if you had:
```
internal::YouTubeRewriteStatus result = internal::THE_MAX_VALUE;

if (corrected_url.query().find("enablejsapi=1") != std::string::npos) {
#if defined(OS_ANDROID)
  result = internal::SUCCESS_ENABLEJSAPI;
#else
  RecordYouTubeRewriteUMA(...);
  return GURL();
#endif
}

[...]

if (result == internal) {
    result = invalid_url ? internal::SUCCESS_PARAMS_REWRITE
                         : internal::SUCCESS);
}

RecordYouTubeRewriteUMA(result);

return [...];
```

[kdsilva, 2016/08/09 10:56:26]

Done.

   }
 
   // Change the path to use the YouTube HTML5 API
   std::string path = corrected_url.path();
   path.replace(path.find("/v/"), 3, "/embed/");
 
   url::Replacements<char> r;
   r.SetPath(path.c_str(), url::Component(0, path.length()));
 
-  RecordYouTubeRewriteUMA(invalid_url ? internal::SUCCESS_PARAMS_REWRITE
-                                      : internal::SUCCESS);
+  if (!android_enablejsapi)
+    RecordYouTubeRewriteUMA(invalid_url ? internal::SUCCESS_PARAMS_REWRITE
+                                        : internal::SUCCESS);

[mlamouri (slow - plz ping), 2016/08/08 19:50:25]

style: add { } when there is more than a line.

[kdsilva, 2016/08/09 10:56:26]

Done.

   return corrected_url.ReplaceComponents(r);
 }