Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: net/quic/core/congestion_control/pacing_sender.h

Issue 2228613002: Rollback of internal changelist 128865569. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129053230
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/congestion_control/pacing_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/congestion_control/pacing_sender.h
diff --git a/net/quic/core/congestion_control/pacing_sender.h b/net/quic/core/congestion_control/pacing_sender.h
index 55ad1991a053f0a7e6e4f99d5d672470ec535908..68ef80bd1b91cd87ab07b26ac33e7e5add83a168 100644
--- a/net/quic/core/congestion_control/pacing_sender.h
+++ b/net/quic/core/congestion_control/pacing_sender.h
@@ -27,13 +27,16 @@ namespace net {
class NET_EXPORT_PRIVATE PacingSender : public SendAlgorithmInterface {
public:
- PacingSender();
+ // Create a PacingSender to wrap the specified sender. |alarm_granularity|
+ // indicates to the pacer to send that far into the future, since it should
+ // not expect a callback before that time delta. |initial_packet_burst| is
+ // the number of packets sent without pacing after quiescence.
+ PacingSender(SendAlgorithmInterface* sender,
+ QuicTime::Delta alarm_granularity,
+ uint32_t initial_packet_burst);
~PacingSender() override;
void SetMaxPacingRate(QuicBandwidth max_pacing_rate);
- // Sets the underlying sender. Takes ownership of |sender| if |owns_sender| is
- // true.
- void SetSender(SendAlgorithmInterface* sender, bool owns_sender);
// SendAlgorithmInterface methods.
void SetFromConfig(const QuicConfig& config,
@@ -67,8 +70,12 @@ class NET_EXPORT_PRIVATE PacingSender : public SendAlgorithmInterface {
// End implementation of SendAlgorithmInterface.
private:
- // Underlying sender. Owned if |owns_sender_| is true.
- SendAlgorithmInterface* sender_;
+ std::unique_ptr<SendAlgorithmInterface> sender_; // Underlying sender.
+ // The estimated system alarm granularity.
+ const QuicTime::Delta alarm_granularity_;
+ // Configured maximum size of the burst coming out of quiescence. The burst
+ // is never larger than the current CWND in packets.
+ const uint32_t initial_packet_burst_;
// If not QuicBandidth::Zero, the maximum rate the PacingSender will use.
QuicBandwidth max_pacing_rate_;
@@ -78,7 +85,6 @@ class NET_EXPORT_PRIVATE PacingSender : public SendAlgorithmInterface {
QuicTime last_delayed_packet_sent_time_;
QuicTime ideal_next_packet_send_time_; // When can the next packet be sent.
mutable bool was_last_send_delayed_; // True when the last send was delayed.
- bool owns_sender_; // True if PacingSender owns |sender_|.
DISALLOW_COPY_AND_ASSIGN(PacingSender);
};
« no previous file with comments | « no previous file | net/quic/core/congestion_control/pacing_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698