Implement Harmony textfield border

Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164, 635160
Committed: https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148
Cr-Commit-Position: refs/heads/master@{#410754}

[Evan Stade, 2016-08-08 18:54:50]

Description was changed from

==========
Implemente Harmony textfield border

BUG=
==========

to

==========
Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using
for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164,635160
==========

[Evan Stade, 2016-08-08 18:54:50]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-08-08 19:24:22]

And not to be confused with Unity.

https://codereview.chromium.org/2228593002/diff/40001/ui/views/controls/focus...
File ui/views/controls/focusable_border.cc (right):

https://codereview.chromium.org/2228593002/diff/40001/ui/views/controls/focus...
ui/views/controls/focusable_border.cc:52: gfx::RectF
rect((gfx::Rect(view.GetLocalBounds())));
I'm surprised you're using floating point for this stuff. But presumably it
gives you the effect you want.

https://codereview.chromium.org/2228593002/diff/40001/ui/views/examples/textf...
File ui/views/examples/textfield_example.cc (right):

https://codereview.chromium.org/2228593002/diff/40001/ui/views/examples/textf...
ui/views/examples/textfield_example.cc:68: auto MakeRow = [layout](View* view1,
View* view2) {
tricky

[sky, 2016-08-08 19:24:32]

Sorry, meant to LGTM

[Evan Stade, 2016-08-08 22:19:40]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:20:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:15:04]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2016-08-09 01:00:12]

estade@chromium.org changed reviewers:
+ tapted@chromium.org

[Evan Stade, 2016-08-09 01:00:13]

+tapted for ui/views/cocoa

[Evan Stade, 2016-08-09 01:00:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 01:00:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:08:05]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[tapted, 2016-08-09 01:35:13]

lgtm if the following makes things happy (and yeah makes sense -
bridged_native_widget_unittest.mm tests some tricky OS-integration and
initialization flows, so it isn't using ViewsTestBase)

https://codereview.chromium.org/2228593002/diff/60001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_native_widget_unittest.mm (right):

https://codereview.chromium.org/2228593002/diff/60001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_native_widget_unittest.mm:266: }
ui::CocoaTest::TearDown() after the ::Uninitialize

https://codereview.chromium.org/2228593002/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2228593002/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:1736: if (false &&
ui::MaterialDesignController::IsSecondaryUiMaterial()) {
The `if (false &&` - may have crept in while tracing

[Evan Stade, 2016-08-09 01:39:29]

https://codereview.chromium.org/2228593002/diff/60001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_native_widget_unittest.mm (right):

https://codereview.chromium.org/2228593002/diff/60001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_native_widget_unittest.mm:266: }
On 2016/08/09 01:35:13, tapted wrote:
> ui::CocoaTest::TearDown() after the ::Uninitialize

thanks, done

https://codereview.chromium.org/2228593002/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2228593002/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:1736: if (false &&
ui::MaterialDesignController::IsSecondaryUiMaterial()) {
On 2016/08/09 01:35:13, tapted wrote:
> The `if (false &&` - may have crept in while tracing

oh yea, whoops. Nice catch

[Evan Stade, 2016-08-09 01:39:51]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-08-09 01:39:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2228593002/#ps80001
(title: "tapted to the resuce")

[commit-bot: I haz the power, 2016-08-09 01:40:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:48:16]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Evan Stade, 2016-08-09 17:39:32]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-08-09 17:40:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:31:35]

Description was changed from

==========
Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using
for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164,635160
==========

to

==========
Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using
for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164,635160
==========

[commit-bot: I haz the power, 2016-08-09 18:31:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-09 18:33:33]

Description was changed from

==========
Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using
for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164,635160
==========

to

==========
Implement Harmony textfield border

In case it's unfamiliar, "Harmony" is the name of the version of MD we're using
for secondary UI in chrome (dialogs, bubbles, etc.).

BUG=635164,635160

Committed: https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148
Cr-Commit-Position: refs/heads/master@{#410754}
==========

[commit-bot: I haz the power, 2016-08-09 18:33:34]

Patchset 5 (id:??) landed as
https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148
Cr-Commit-Position: refs/heads/master@{#410754}