Chromium Code Reviews
DescriptionIn find_unmapped_histograms.py, remove comments from histogram names
While scanning the source code for histogram matches, remove C++-style
and C-style comments from histogram names. This reduces the number of
false-negatives that the script produces.
Before / after diff:
WARNING: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc contains non-literal histogram name <uma>
WARNING: cc/raster/one_copy_raster_buffer_provider.cc contains non-literal histogram name <base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.OneCopy">
- WARNING: content/browser/renderer_host/p2p/socket_host_udp.cc contains non-literal histogram name <"WebRTC.SystemSendPacketDuration_UDP" /* name */>
- WARNING: ui/events/blink/input_handler_proxy.cc contains non-literal histogram name <// So named for historical reasons.
- "Event.Latency.RendererImpl.GestureScroll2">
WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time.c_str(>
WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time_per.c_str(>
--- 20,23 ----
R=isherman@chromium.org
BUG=635726
Committed: https://crrev.com/986ac05bfafd2f0016f282473324011326b52947
Cr-Commit-Position: refs/heads/master@{#411567}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 10 (5 generated)
|