Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2228573003: In find_unmapped_histograms.py, remove comments from histogram names (Closed)

Created:
4 years, 4 months ago by Adam Rice
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@find_unmapped_histograms_non_literal
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In find_unmapped_histograms.py, remove comments from histogram names While scanning the source code for histogram matches, remove C++-style and C-style comments from histogram names. This reduces the number of false-negatives that the script produces. Before / after diff: WARNING: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc contains non-literal histogram name <uma> WARNING: cc/raster/one_copy_raster_buffer_provider.cc contains non-literal histogram name <base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.OneCopy"> - WARNING: content/browser/renderer_host/p2p/socket_host_udp.cc contains non-literal histogram name <"WebRTC.SystemSendPacketDuration_UDP" /* name */> - WARNING: ui/events/blink/input_handler_proxy.cc contains non-literal histogram name <// So named for historical reasons. - "Event.Latency.RendererImpl.GestureScroll2"> WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time.c_str(> WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time_per.c_str(> --- 20,23 ---- R=isherman@chromium.org BUG=635726 Committed: https://crrev.com/986ac05bfafd2f0016f282473324011326b52947 Cr-Commit-Position: refs/heads/master@{#411567}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/metrics/histograms/find_unmapped_histograms.py View 1 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Adam Rice
4 years, 4 months ago (2016-08-09 06:14:16 UTC) #1
Ilya Sherman
LGTM, thanks =)
4 years, 4 months ago (2016-08-10 06:19:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228573003/20001
4 years, 4 months ago (2016-08-12 06:35:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 07:15:39 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:18:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/986ac05bfafd2f0016f282473324011326b52947
Cr-Commit-Position: refs/heads/master@{#411567}

Powered by Google App Engine
This is Rietveld 408576698