Tracing V2: Proto message and utils improvements.

components/tracing/core/proto_zero_message.h

Index: components/tracing/core/proto_zero_message.h
diff --git a/components/tracing/core/proto_zero_message.h b/components/tracing/core/proto_zero_message.h
index d7fe1d4270e5a99474e940091f39dd69ac5ee4bf..59858aabcadb924cbf583b2ca570c982126265c0 100644
--- a/components/tracing/core/proto_zero_message.h
+++ b/components/tracing/core/proto_zero_message.h
@@ -15,6 +15,7 @@
 #include "base/macros.h"
 #include "base/template_util.h"
 #include "build/build_config.h"
+#include "components/tracing/core/proto_utils.h"
 #include "components/tracing/core/scattered_stream_writer.h"
 #include "components/tracing/tracing_export.h"
 
@@ -61,13 +62,45 @@ class TRACING_EXPORT ProtoZeroMessage {
  protected:
   ProtoZeroMessage();
 
-  void AppendVarIntU64(uint32_t field_id, uint64_t value);
-  void AppendVarIntU32(uint32_t field_id, uint32_t value);
-  void AppendFloat(uint32_t field_id, float value);
-  void AppendDouble(uint32_t field_id, double value);
+  // Proto types: uint64, uint32, int64, int32, bool, enum.
+  template <typename T>
+  void AppendVarInt(uint32_t field_id, T value) {

[alph, 2016/08/08 19:59:50]

Maybe DCHECK the value is positive?

[kraynov, 2016/08/09 12:32:05]

It's suitable for signed value as well. Added a comment.

+    if (nested_message_)
+      EndNestedMessage();
+
+    uint8_t buffer[proto::kMaxSingilarFieldEncodedSize];
+    uint8_t* pos = buffer;
+
+    pos = proto::WriteVarInt(proto::MakeTagVarInt(field_id), pos);
+    pos = proto::WriteVarInt(value, pos);
+    WriteToStream(buffer, pos);
+  }
+
+  // Proto types: sint64, sint32.
+  template <typename T>
+  void AppendSignedVarInt(uint32_t field_id, T value) {
+    AppendVarInt(field_id, proto::ZigZagEncode(value));
+  }
+
+  // Proto types: fixed64, sfixed64, fixed32, sfixed32, double, float.
+  template <typename T>
+  void AppendFixed(uint32_t field_id, T value) {
+    if (nested_message_)
+      EndNestedMessage();
+
+    uint8_t buffer[proto::kMaxSingilarFieldEncodedSize];
+    uint8_t* pos = buffer;
+
+    pos = proto::WriteVarInt(proto::MakeTagFixed<T>(field_id), pos);
+    memcpy(pos, &value, sizeof(T));
+    pos += sizeof(T);
+    // TODO(kraynov) Optimize memcpy performance, see http://crbug.com/624311 .
+    WriteToStream(buffer, pos);
+  }
+
+  // TODO(kraynov) AppendTinyInt.
   void AppendString(uint32_t field_id, const char* str);
   void AppendBytes(uint32_t field_id, const void* value, size_t size);
-  // TODO(kraynov): implement AppendVarIntS32/64(...) w/ zig-zag encoding.
 
   // Begins a nested message, using the static storage provided by the parent
   // class (see comment in |nested_messages_arena_|). The nested message ends